Context Navigation

Modify ↓

#12666 closed defect (fixed)

Reported by:	Ryan J Ollos	Owned by:	Ryan J Ollos
Priority:	normal	Milestone:	1.3.2
Component:	roadmap	Version:
Severity:	normal	Keywords:
Cc:		Branch:
Release Notes:	The path `/milestone` redirects to `/roadmap` even when a user doesn't have `MILESTONE_VIEW`.
API Changes:
Internal Changes:

If user has MILESTONE_VIEW /milestone redirects to /roadmap. A PermissionError is displayed if user doesn't have MILESTONE_VIEW.

We could make the behavior consistent by always redirecting to /roadmap with a patch such as:

diff --git a/trac/ticket/roadmap.py b/trac/ticket/roadmap.py
index d1328a4c3..c5c8952d1 100644

                class MilestoneModule(Component):
     def process_request(self, req):
         milestone_id = req.args.get('id')
+        if not milestone_id:
+            req.redirect(req.href.roadmap())
         req.perm(self.realm, milestone_id).require('MILESTONE_VIEW')
         add_link(req, 'up', req.href.roadmap(), _("Roadmap"))
-…
+               class MilestoneModule(Component):
         elif action == 'delete':
             return self._render_confirm(req, milestone)
-        if not milestone.name:
-            req.redirect(req.href.roadmap())
         return self._render_view(req, milestone)
     # Public methods

Release Notes:	modified (diff)

Resolution:	→ fixed
Status:	assigned → closed

Committed to trunk in r15367.

Change Properties

Summary:
Description:	If user has `MILESTONE_VIEW` `/milestone` redirects to `/roadmap`. A `PermissionError` is displayed if user doesn't have `MILESTONE_VIEW`. We could make the behavior consistent by always redirecting to `/roadmap` with a patch such as: {{{#!diff diff --git a/trac/ticket/roadmap.py b/trac/ticket/roadmap.py index d1328a4c3..c5c8952d1 100644 --- a/trac/ticket/roadmap.py +++ b/trac/ticket/roadmap.py @@ -736,6 +736,8 @@ class MilestoneModule(Component): def process_request(self, req): milestone_id = req.args.get('id') + if not milestone_id: + req.redirect(req.href.roadmap()) req.perm(self.realm, milestone_id).require('MILESTONE_VIEW') add_link(req, 'up', req.href.roadmap(), _("Roadmap")) @@ -767,9 +769,6 @@ class MilestoneModule(Component): elif action == 'delete': return self._render_confirm(req, milestone) - if not milestone.name: - req.redirect(req.href.roadmap()) - return self._render_view(req, milestone) # Public methods }}} You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:	The path `/milestone` redirects to `/roadmap` even when a user doesn't have `MILESTONE_VIEW`.
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Ryan J Ollos.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Ryan J Ollos to the specified user.

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.