BrowserModule displays wrong author in SVN keywords on HEAD Revision

[markusbloch@…]

Hello,

I'm responsible for the Trac environment located at ​https://svn.fhem.de/trac/

We're using only the BrowserModule to display our SVN repository.

The $Id$ replacement always contains the wrong author when opening the file content in HEAD revision.

Example: The following file was last modified by me (markusbloch) at revision 11987, but the displayed author in $Id$ contains the author name of the latest revision HEAD and not revision 11987 (were this file was last modified)

my file: ​https://svn.fhem.de/trac/browser/trunk/fhem/FHEM/98_version.pm HEAD author: ​https://svn.fhem.de/trac/changeset/HEAD/

Only when explicitly selecting my file at revision 11987, the author is displayed correctly: ​https://svn.fhem.de/trac/browser/trunk/fhem/FHEM/98_version.pm?rev=11987

So when browing the repository, all files were displayed by Trac with the author name of the latest commit (HEAD) no matter if the file was modified during the latest commit or not.

This problem also occurs when using the ZIP download functionality for trunk. All files contains $Id$ with the author of the latest commit.

Our project relies on correct $Id$ replacement, because we have about 60 developers, were each is commiting changes to specific files only. The developed application uses the author names from $Id$.

The problem could be verified on Trac 1.0.2 (used at svn.fhem.de) and latest Trac 1.2 (virtual machine on my laptop)

Please use the correct author name of the last change revision per file and not the author name of HEAD revision.

Please let me know, if I can help you.

Kind Regards

Markus Bloch

[markusbloch@…]

I wanted to attach some screenshots for clarification but your Trac (trac.edgewall.org) raises an error when click on file upload.

IndexError: pop from empty list

GET: /attachment/ticket/12655/

[Jun Omae]

Replying to markusbloch@…:

I wanted to attach some screenshots for clarification but your Trac (trac.edgewall.org) raises an error when click on file upload.

That's #11184. Please try to upload with English language.

[markusbloch@…]

wrong author name

[markusbloch@…]

correct username

[Markus Bloch <markusbloch@…>]

Replying to Jun Omae:

Replying to markusbloch@…:

I wanted to attach some screenshots for clarification but your Trac (trac.edgewall.org) raises an error when click on file upload.

That's #11184. Please try to upload with English language.

Thank you, now it works. I attached the mentioned screenshots.

[Jun Omae]

Could you please try the following patch?

tracopt/versioncontrol/svn/svn_fs.py

@@ -1206 +1206 @@
             return self._read_substitute(self.stream, n)
 
     def _get_revprop(self, name):
-        return fs.revision_prop(self.fs_ptr, self.node.rev, name, self.pool())
+        return fs.revision_prop(self.fs_ptr, self.node.created_rev, name,
+                                self.pool())
 
     def _split_keywords(self, keywords):
         return filter(None, self.KEYWORD_SPLIT_RE.split(keywords or ''))

[Markus Bloch <markusbloch@…>]

Replying to Jun Omae:

Could you please try the following patch?

tracopt/versioncontrol/svn/svn_fs.py

@@ -1206 +1206 @@
             return self._read_substitute(self.stream, n)
 
     def _get_revprop(self, name):
-        return fs.revision_prop(self.fs_ptr, self.node.rev, name, self.pool())
+        return fs.revision_prop(self.fs_ptr, self.node.created_rev, name,
+                                self.pool())
 
     def _split_keywords(self, keywords):
         return filter(None, self.KEYWORD_SPLIT_RE.split(keywords or ''))

I applied the patch and it works now perfectly, thanks a lot.

[Jun Omae]

Thanks for the feedback! I'll apply it with unit tests to 1.0-stable branch.

[Jun Omae]

Fixed in [15342] and merged in [15343-15344].