Edgewall Software

Changes between Initial Version and Version 1 of Ticket #12572, comment 1


Ignore:
Timestamp:
Dec 28, 2018, 6:26:33 PM (3 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12572, comment 1

    initial v1  
    11This looks like a good start.
    2 1. I think we'll want the download link centered under the `ul.entries`, and some styling is needed.
     21. I think we'll want the download link centered under the `ul.entries`, and some styling would be nice.
    331. The feature will need tests (TracDev/SubmittingPatches#Whatisagoodpatch)
    441. We might want to name the diff using the resource name (e.g. `ticket12572_comment2.diff` or `WikiStart.diff`). It looks like the resource can be obtained from `context.resource`. I'm unsure if unique names from each download link are needed in the case that the resource has more than one patch in the content.