Edgewall Software
Modify ↓

Opened 8 years ago

Last modified 5 years ago

#12572 new enhancement

Add a download link to patch/diff renderer

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: next-major-releases
Component: wiki system Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

It would be nice to be able to download a patch that is posted inline of a comment. For example: comment:1:ticket:12546. We could add a download link to the patch renderer. I'd use it to grab a URL that could be passed to wget.

Attachments (1)

DownloadPatch-trunk@16826.patch​ (1.6 KB ) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (4)

by anonymous, 6 years ago

Attachment: DownloadPatch-trunk@16826.patch​ added

comment:1 by Ryan J Ollos, 6 years ago

This looks like a good start.

  1. I think we'll want the download link centered under the ul.entries, and some styling would be nice.
  2. The feature will need tests (TracDev/SubmittingPatches#Whatisagoodpatch)
  3. We might want to name the diff using the resource name (e.g. ticket12572_comment2.diff or WikiStart.diff). It looks like the resource can be obtained from context.resource. I'm unsure if unique names from each download link are needed in the case that the resource has more than one patch in the content.
Last edited 6 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Ryan J Ollos, 5 years ago

Milestone: next-dev-1.3.x → next-dev-1.5.x

Milestone renamed

comment:3 by Ryan J Ollos, 5 years ago

Milestone: next-dev-1.5.x → next-major-releases

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.