Edgewall Software

Opened 8 years ago

Last modified 4 years ago

#12558 closed enhancement

Add contextmanager for Popen — at Version 3

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.3.1
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Refactored code to use Popen context manager.

API Changes:

Added context manager for Popen to trac.util.compat. The code is copied from the Python 3.2 implementation.

Internal Changes:

Description

I'm using Popen in a test case and rather than duplicate code again for closing the file descriptors, I thought I would investigate the following idea.

The Popen class has a context manager ​since Python 3.2. We could subclass Popen in trac.util.compat and copy the __enter__ and __exit__ methods.

Change History (3)

comment:1 by Ryan J Ollos, 8 years ago

Proposed changes in log:rjollos.git:t12558_popen.1.

Last edited 8 years ago by Ryan J Ollos (previous) (diff)

comment:2 by Ryan J Ollos, 8 years ago

Minor change in r15074, and I corrected the link to my proposed changes in comment:1.

comment:3 by Ryan J Ollos, 8 years ago

API Changes: modified (diff)
Release Notes: modified (diff)

Committed to trunk in r15077.

Note: See TracTickets for help on using tickets.