Better handling of ChangeLog style commit messages

[Mikael Hallendal]

It's pretty common and useful to paste the ChangeLog message as the commit log message. Would be nice if the timeline view could show this message nicely "tagged". For example

               * src/foo.c: oaiwjefoiewajf
               - woaifjowijf

Could keep a link to the svn:/src/foo.c and format the text nicely.

Any thoughts?

[daniel]

See also #352.

[oohlaf@…]

Currently a - or + isn't recognised as second or third level. Ticket #352 does add newlines so it makes it a bit more readable, but thats not the same as a nested level.

 * One
   - Two
     + Three

Or some people prefer:

 * One
   + Two
     - Three

The GNU coding standard of change logs is to put the modified filename first followed by a colon and can happen at every level. Sometimes it contains the changed functions in parantheses.

Problem is that Trac does not know in which directory the file is. It could parse the set of changed files from the changeset and use the biggest match.

2002-07-14  John Doe  <jdoe@gnu.org>
 * sew.c (sew, main): Make it sew. Patch by charly@sew.me.com.

So if the changeset contains a modified/added file trunk/project/src/sew.c it could contain a link to the source browser.

There are a lot of projects who follow the GNU coding style (some because of historic reasons).

[Christian Boos]

Since [1561], changelog-style commit messages should be correctly formatted. However, automatically adding links for filenames is still an open issue.

[Christian Boos]

However, automatically adding links for filenames is still an open issue.

That should be tracked in #1200.

[Christian Boos]

I'd like to reopen this one, as I think I've come with an improved way to handle the wiki lists, which is more robust and as a side-effect handles the usual Changelog styles much better.

A few examples:

1. Deeply indented list (using spaces)

The text

Thu Apr 20 00:53:28 PDT 2006  Christian Hammond <chipx86@chipx86.com>

	* NEWS:
	  - Add the release datestamp.

Mon Apr 17 01:00:21 PDT 2006  Christian Hammond <chipx86@chipx86.com>

	* src/galago.defs:
	  - Remove the {set,get}_exit_with_daemon() wrappers.

Mon Apr 17 00:25:01 PDT 2006  Christian Hammond <chipx86@chipx86.com>

	* NEWS:
	* configure.ac:
	  - Bump the version to 0.5.0.
	  - Update the copyrights.

will be rendered like this:

---

Thu Apr 20 00:53:28 PDT 2006 Christian Hammond <chipx86@chipx86.com>

• NEWS:
  • Add the release datestamp.

Mon Apr 17 01:00:21 PDT 2006 Christian Hammond <chipx86@chipx86.com>

• src/galago.defs:
  • Remove the {set,get}_exit_with_daemon() wrappers.

Mon Apr 17 00:25:01 PDT 2006 Christian Hammond <chipx86@chipx86.com>

• NEWS:
• configure.ac:
  • Bump the version to 0.5.0.
  • Update the copyrights.

---

instead of:

---

Thu Apr 20 00:53:28 PDT 2006 Christian Hammond <chipx86@…>

• NEWS:
  • Add the release datestamp.

Mon Apr 17 01:00:21 PDT 2006 Christian Hammond <chipx86@…>

• src/galago.defs:
  • Remove the {set,get}_exit_with_daemon() wrappers.

Mon Apr 17 00:25:01 PDT 2006 Christian Hammond <chipx86@…>

• NEWS:
• configure.ac:
  • Bump the version to 0.5.0.
  • Update the copyrights.

---

2. Tab indented list, direct continuation

The text:

2003-09-18 23:26  Chris Hanson <cph@zurich.ai.mit.edu>

	* imail/imail-imap.scm (1.200): Fix problem with obsolete use of
	backslash in symbols.

2003-09-18 20:39  Chris Hanson <cph@zurich.ai.mit.edu>

	* runtime/: random.scm (14.30), runtime.pkg (14.457): Implement
	external representation for random-state objects.

will be rendered like this:

---

2003-09-18 23:26 Chris Hanson <cph@zurich.ai.mit.edu>

• imail/imail-imap.scm (1.200): Fix problem with obsolete use of backslash in symbols.

2003-09-18 20:39 Chris Hanson <cph@zurich.ai.mit.edu>

• runtime/: random.scm (14.30), runtime.pkg (14.457): Implement external representation for random-state objects.

---

instead of:

---

2003-09-18 23:26 Chris Hanson <cph@…>

• imail/imail-imap.scm (1.200): Fix problem with obsolete use of backslash in symbols.

2003-09-18 20:39 Chris Hanson <cph@…>

• runtime/: random.scm (14.30), runtime.pkg (14.457): Implement external representation for random-state objects.

---

The attachement:robust_lists_r3271.diff provide the necessary changes. Surprisingly, all the existing unit tests still pass :)

[Christian Boos]

That was not really apparent in the above example, as they both were using tabs for indenting instead of space, but the patch actually fixes lists which start at an arbitrary depth:

               * src/foo.c: oaiwjefoiewajf
                - woaifjowijf

would be rendered as:

---

• src/foo.c: oaiwjefoiewajf
  • woaifjowijf

---

instead of:

---

• src/foo.c: oaiwjefoiewajf
  • woaifjowijf

---

[Christian Boos]

Refactor the list formatter