Context Navigation

Modify ↓

#12451 closed defect (fixed)

Reported by:	Ryan J Ollos	Owned by:	Ryan J Ollos
Priority:	normal	Milestone:	0.12.8
Component:	general	Version:
Severity:	normal	Keywords:
Cc:		Branch:
Release Notes:	Fixed error reports not sent to trac-hacks.org if `home_page` or `url` attribute uses HTTPS protocol.
API Changes:
Internal Changes:

The issue is due to use of startswith to compare against the string http://trac-hacks.org: tags/trac-0.12.7/trac/web/main.py@:586,612#L578 .

Proposed change:

diff --git a/trac/web/main.py b/trac/web/main.py
index ee7b0bb..9808ecf 100644

                from pprint import pformat, pprint
 import re
 import sys
 import traceback
+from urlparse import urlparse
 from genshi.builder import tag
 from genshi.output import DocType
-…
+               def send_internal_error(env, req, exc_info):
             faulty_plugins.sort(key=lambda p: p['frame_idx'])
             if faulty_plugins:
                 info = faulty_plugins[0]['info']
+                home_page = info.get('home_page', '')
                 if 'trac' in info:
                     tracker = info['trac']
                 elif info.get('home_page', '').startswith(th):
+                elif urlparse(home_page).netloc == urlparse(th).netloc:
                     tracker = th
                     plugin_name = info.get('home_page', '').rstrip('/') \
                                                            .split('/')[-1]

Patch was created against the trunk. I will need to test it for 1.0-stable and 0.12-stable.

In [14717], .netloc attribute is available since Python 2.6. For 1.0-stable and 0.12-stable, we should use urlparse(home_page)[1] instead.

Committed to 0.12-stable in [14717,14718], merged to 1.0-stable in [14719], merged to trunk in [14720].

CI tests will fail on 0.12 branch unless we pin the Pygments version.

Version 0, edited 8 years ago by Ryan J Ollos (next)

Change Properties

Summary:
Description:	The issue is due to use of `startswith` to compare against the string `http://trac-hacks.org`: [browser:tags/trac-0.12.7/trac/web/main.py@:586,612#L578]. Proposed change: {{{#!diff diff --git a/trac/web/main.py b/trac/web/main.py index ee7b0bb..9808ecf 100644 --- a/trac/web/main.py +++ b/trac/web/main.py @@ -31,6 +31,7 @@ from pprint import pformat, pprint import re import sys import traceback +from urlparse import urlparse from genshi.builder import tag from genshi.output import DocType @@ -670,9 +671,10 @@ def send_internal_error(env, req, exc_info): faulty_plugins.sort(key=lambda p: p['frame_idx']) if faulty_plugins: info = faulty_plugins[0]['info'] + home_page = info.get('home_page', '') if 'trac' in info: tracker = info['trac'] - elif info.get('home_page', '').startswith(th): + elif urlparse(home_page).netloc == urlparse(th).netloc: tracker = th plugin_name = info.get('home_page', '').rstrip('/') \ .split('/')[-1] }}} Patch was created against the trunk. I will need to test it for 1.0-stable and 0.12-stable. You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:	Fixed error reports not sent to trac-hacks.org if `home_page` or `url` attribute uses HTTPS protocol.
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Ryan J Ollos.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Ryan J Ollos to the specified user.

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.