Edgewall Software

Opened 7 years ago

Closed 7 years ago

#12378 closed defect (fixed)

Wiki history page uses class="ticket" for div#content — at Version 4

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 1.2
Component: wiki system Version: 1.0.10
Severity: normal Keywords:
Cc: Branch:
Release Notes:

history_view.html uses ${resource.realm} rather than hard-coded ticket class for #content.

API Changes:
Internal Changes:


I noticed there is class="ticket" in wiki history page while creating/customizing styles for our service. I think we should use class="wiki" for wiki history page.

$ curl -s 'https://trac.edgewall.org/wiki/WikiStart?action=history' | grep -n 'class="ticket"'
128:    <div id="content" class="ticket">

Change History (4)

comment:1 by Christian Boos, 7 years ago

Looks like it's hard-coded in the template. We could use resource.realm.

comment:2 by Christian Boos, 7 years ago

Right, that's what diff_view.html already uses:

<div id="content" class="${resource.realm}">

comment:3 by Jun Omae, 7 years ago

Component: generalwiki system
Milestone: next-dev-1.1.x1.2
Owner: set to Jun Omae
Status: newassigned

Thanks. I found history_view.html has hard-coded class="ticket".

  • trac/templates/history_view.html

    diff --git a/trac/templates/history_view.html b/trac/templates/history_view.html
    index c4b3191c9..5163b4316 100644
    a b  
    2929  </head>
    3131  <body>
    32     <div id="content" class="ticket">
     32    <div id="content" class="${resource.realm}">
    3333      <h1 i18n:msg="name">Change History for <a href="${url or url_of(resource)}">${name or name_of(resource)}</a></h1>
    3535      <form py:if="history" id="history" class="printableform" method="get" action="">

comment:4 by Jun Omae, 7 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [14601].

Note: See TracTickets for help on using tickets.