Changes between Initial Version and Version 1 of Ticket #12287, comment 1
- Timestamp:
- Dec 29, 2015, 6:44:13 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #12287, comment 1
initial v1 1 1 Proposed changes in [attachment:t12287.diff]. 2 2 3 I'm unsure which single class should return //System Information// for `dnspython` since [browser:plugins/1.0/spam-filter/setup.py@14387:60,87-89#L58 3 Components] depend on the package. We could have a class such as `tracspamfilter.filtersystem.FilterSystem` return the package info. Or we could check in `get_systeminfo` which other packages are enabled. #12294 would cleanly resolve the issue as well.3 I'm unsure which single class should return //System Information// for `dnspython` since [browser:plugins/1.0/spam-filter/setup.py@14387:60,87-89#L58 3 Components] depend on the package. We could have a class such as `tracspamfilter.filtersystem.FilterSystem` return the package info. We could use inheritance, but that doesn't seemed warranted for such a simple issue. We could check in `get_systeminfo` which other packages are enabled. #12294 would cleanly resolve the issue as well. 4 4 5 5 Also, considering whether to use `get_pkginfo(...).get('version', '')` rather than`get_pkginfo(...)['version']` (comment:1:ticket:12294).
