Opened 9 years ago
Closed 7 years ago
#12231 closed enhancement (fixed)
Add is_authenticated property to Request class — at Version 9
| Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.3.2 |
| Component: | general | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: |
Added |
||
| Internal Changes: | |||
Description
The proposed change is a minor simplification motivated by this comment: tags/trac-1.0.9/trac/web/auth.py@:202#L193. The is_authenticated property should make the code slightly more clear, but I ask for comments on whether or not others feel the change makes things more clear.
Change History (9)
comment:1 by , 9 years ago
follow-up: 3 comment:2 by , 8 years ago
Just my 2 cents. I think the code better shows what's going on with the changes.
A nice benefit may be that the term anonymous can easier be translated in the future.
comment:3 by , 8 years ago
A nice benefit may be that the term anonymous can easier be translated in the future.
No. I don't think we should do it. We should translate only when anonymous is displayed.
comment:4 by , 8 years ago
Right, if you need anonymous to be translated when you display it to the user you can use Chrome.authorinfo or Chrome.format_author. Both have been improved by 1.1.6.
comment:6 by , 8 years ago
| Milestone: | 1.2 |
|---|---|
| Resolution: | → wontfix |
| Status: | assigned → closed |
I don't think this is very useful, so closing.
comment:7 by , 7 years ago
| Milestone: | → 1.3.2 |
|---|---|
| Resolution: | wontfix |
| Status: | closed → reopened |
Discussed in #12719, we'll move ahead with these changes.
comment:8 by , 7 years ago
| Status: | reopened → assigned |
|---|
comment:9 by , 7 years ago
| API Changes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Fixed in r15682.
Proposed changes in log:rjollos.git:t12231_req_is_authenticated.