Edgewall Software

Changes between Version 1 and Version 2 of Ticket #12206


Ignore:
Timestamp:
Sep 21, 2015, 12:09:00 AM (7 years ago)
Author:
Ryan J Ollos
Comment:

I'm going to propose an API change that is not backward compatible, however I think the behavior can be considered a defect. Currently when [trac] show_email_addresses is False, Chrome.format_author will not obfuscate the email when req is None: tags/trac-1.1.6/trac/web/chrome.py@:1297-1298#L1277.

I think that is undesirable. Instead, the value of [trac] show_email_addresses should always be used when req is None and permissions cannot be checked. I propose that the value of [trac] show_email_addresses should always be used, and only overridden when permissions can be checked (for the resource).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12206

    • Property Summary Notifications should use full name when show_full_name is TrueNotifications should use full name when [trac] show_full_names is True
  • Ticket #12206 – Release Notes

    v1 v2  
     1Notification emails use the author's full name when `[trac] show_full_names` is `True`.
  • Ticket #12206 – API Changes

    v1 v2  
     1`Chrome.format_author` obfuscates emails when `[trac] show_email_addresses` is `False` and `req` evaluates to `False`. Previously emails would never be obfuscated when `req` evaluated to `False`.