Edgewall Software

Changes between Initial Version and Version 4 of Ticket #12182


Ignore:
Timestamp:
Aug 25, 2015, 6:08:36 PM (9 years ago)
Author:
Ryan J Ollos
Comment:

Thanks for review. Committed to trunk in [14273].

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12182

    • Property Owner set to Ryan J Ollos
    • Property Status new → closed
    • Property Resolution → fixed

  • Ticket #12182 – Description

    initial v4  
    1 Discussed in #12179, the API should document that `short_rev` and `display_rev` return a string, and the Subversion implementation should be modified to return a string rather than an integer. Since `short_rev` and `display_rev` call `normalize_rev`, it may be that the latter only needs to be modified.  In fact the docstring for `normalize_rev` seems to suggest that a string should be input: [browser:tags/trac-1.1.6/trac/versioncontrol/api.py@:985#L981].
     1Discussed in #12179, the API should document that `short_rev` and `display_rev` return a string, and the Subversion implementation should be modified to return a string rather than an integer. Since `short_rev` and `display_rev` call `normalize_rev`, it may be that the latter only needs to be modified.

  • Ticket #12182 – Release Notes

    initial v4  
     1`Repository.short_rev` and `Repository.display_rev` always return a string or `None`.