Exception: Missing permissions to report spam

[Ryan J Ollos]

How to Reproduce

While doing a GET operation on /reportspam, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{}

User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0

System Information

System information not available

Enabled Plugins

Plugin information not available

Python Traceback

Traceback (most recent call last):
  File "build/bdist.linux-i686/egg/trac/web/main.py", line 550, in _dispatch_request
    dispatcher.dispatch(req)
  File "build/bdist.linux-i686/egg/trac/web/main.py", line 243, in dispatch
    resp = chosen_handler.process_request(req)
  File "/srv/trac-hacks.org/pve/lib/python2.6/site-packages/TracSpamFilter-1.0.6.dev0-py2.6.egg/tracspamfilter/report.py", line 40, in process_request
    raise Exception(_("Missing permissions to report spam"))
Exception: Missing permissions to report spam

[Ryan J Ollos]

I suggest the following untested changes to plugins/1.0/spam-filter/tracspamfilter/report.py@13308:39-42#L25​:

-        if not 'SPAM_REPORT' in req.perm:
-            raise Exception(_("Missing permissions to report spam"))
-         if not 'page' in req.args:
-             raise Exception(_("No page supplied to report as spam"))
+        req.perm.require('SPAM_REPORT')
+        if 'page' not in req.args:
+            raise TracError(_("No page supplied to report as spam"))

TracError will need to be imported on line 19.

[Ryan J Ollos]

The attached patch (attachment:t12134_missing_imports.patch​) is unrelated to the error reported in this ticket, but fixes some missing imports and an unbound reference error.

[Ryan J Ollos]

Fixed in [14339:14340].