Ticket ids in batch ticket notification should be sorted

[Jun Omae]

Ticket ids in batch ticket notification are not sorted like this, though those are sorted in timeline view.

Batch modification to #886, #31, #53, #633, #918, #1084, #1113, #1890, #1962, ...

-- 
Tickets URL: <http://trac.edgewall.org/query?id=886%2C31%2C53%2C633%2C918%2C1084%2C1113%2C1890%2C1962%2C2035%2C2141%2C2463%2C3332%2C3386%2C3470%2C....

trac/ticket/notification.py

@@ -545 +545 @@
             self._notify(tickets, new_values, comment, action, author)
 
     def _notify(self, tickets, new_values, comment, action, author):
+        tickets = sorted(tickets)
         self.tickets = tickets
         self.reporter = ''
         self.owner = ''
-        changes_descr = '\n'.join(['%s to %s' % (prop, val)
-                                   for (prop, val) in new_values.iteritems()])
-        tickets_descr = ', '.join(['#%s' % t for t in tickets])
+        changes_descr = '\n'.join('%s to %s' % (prop, val)
+                                  for (prop, val) in new_values.iteritems())
+        tickets_descr = ', '.join('#%s' % t for t in tickets)
         subject = self.format_subj(tickets_descr)
-        link = self.env.abs_href.query(id=','.join([str(t) for t in tickets]))
+        link = self.env.abs_href.query(id=','.join(str(t) for t in tickets))
         self.data.update({
             'tickets_descr': tickets_descr,
             'changes_descr': changes_descr,

Another suggestions for batch ticket notification mail:

• Add unit tests. It doesn't seem to be no unit tests.
• Add Message-ID header. Currently, SMTP server probably adds the header.