Allow to reorder subscription rules using drag-and-drop and submit in bulk in notifications of preferences

[Jun Omae]

In notifications panel in preferences, it needs to submit per adding, removing and reordering a subscription rule. That feels a bit of a pain.

If javascript is enabled in the user's browser, it's useful to allow to reorder subscription rules using drag-and-drop and submit the rules in bulk.

Proposed changes in jomae.git@t11941. In the changes, even if javascript is disabled, it is able to configure per subscription rule.

[Ryan J Ollos]

The changes look good to me. #11682 will implement similar functionality for the Admin enum list tables.

3 small suggestions:

• When hovering over a rule there could be a helpful tooltip, such as Drag to reorder
• An indicator for unsaved changes would be useful. This could be a JavaScript popup when navigating away for the page, though there's probably a better solution. We could use a notice on the page You have unsaved changes, or a background coloring.
• A TracDev/CodingStyle#JavaScript guideline that was previously discussed on the trac-dev mailing list is to prefix jQuery variables with $. For example,

  - var rows = $("#content .subscription-rules .rules");
  + var $rows = $("#content .subscription-rules .rules");
  

[Jun Omae]

Thanks for the reviewing.

3 small suggestions:

• When hovering over a rule there could be a helpful tooltip, such as Drag to reorder
• An indicator for unsaved changes would be useful. This could be a JavaScript popup when navigating away for the page, though there's probably a better solution. We could use a notice on the page You have unsaved changes, or a background coloring.

Updated jomae.git@t11941. $.setWarningUnsavedChanges() function would be added.

• A TracDev/CodingStyle#JavaScript guideline that was previously discussed on the trac-dev mailing list is to prefix jQuery variables with $. For example,

  - var rows = $("#content .subscription-rules .rules");
  + var $rows = $("#content .subscription-rules .rules");
  

Hmm. I tried to modify but got the following error. Genshi substitutes $rows and $rows.on variables in the template. I'd like to leave without changes.

File "/.../src/tracdev/git/trac/notification/templates/prefs_notification.html", line 41, in <Expression u'rows.on'>
  $rows.on("click", ".delete-rule", function() {
UndefinedError: "rows" not defined

[Ryan J Ollos]

Replying to jomae:

Hmm. I tried to modify but got the following error. Genshi substitutes $rows and $rows.on variables in the template. I'd like to leave without changes.

I've run into that issue as well. We may have to reconsider the coding guideline in light of the conflict with Genshi.

Changes look good to me.

[Jun Omae]

Thanks, again! Committed in [13830].