Edgewall Software

Opened 9 years ago

Last modified 9 years ago

#11921 closed defect

"Default language" is selected on Localization preferences panel even when language has been set — at Version 1

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.1.4
Component: general Version:
Severity: normal Keywords: preferences
Cc: Branch:
Release Notes:

Fixed regression in [13323]: Default language was always selected even when a language had been set.

API Changes:
Internal Changes:

Description (last modified by Ryan J Ollos)

This is a regression from #11813 / [13323]. The Default language is always selected on the Localization preferences panel even when a language has been set. The following will fix the issue:

  • trac/prefs/templates/prefs_localization.html 

    diff --git a/trac/prefs/templates/prefs_localization.html b/trac/prefs/templates/prefs_localization.html
index 6d54749..43b0c8a 100644
    a b  
    2727      <tr class="field">
    2828        <th><label for="language">Language:</label></th>
    2929        <td>
    30           <select id="language" name="language" disabled="${'disabled' if not languages else None}"
     30          <select py:with="session_language = settings.session.get('language', '').replace('-', '_')"
     31                  id="language" name="language" disabled="${'disabled' if not languages else None}"
    3132                  title="${_('Translations are currently unavailable') if not languages else None}">
    3233            <option value="">Default language</option>
    3334            <option py:for="locale, language in languages"

Change History (1)

comment:1 by Ryan J Ollos, 9 years ago

Description: modified (diff)
Status: new → assigned
Note: See TracTickets for help on using tickets.