#11854 closed enhancement (fixed)
Split up notification module — at Version 2
Reported by: | Peter Suter | Owned by: | Peter Suter |
---|---|---|---|
Priority: | normal | Milestone: | 1.1.3 |
Component: | notification | Version: | |
Severity: | normal | Keywords: | |
Cc: | Ryan J Ollos | Branch: | |
Release Notes: |
Split up |
||
API Changes: |
Added mail notification helper functions |
||
Internal Changes: |
Description
The Advanced Notification proposal starts with splitting up the trac/notification.py into:
trac/notification/api.py
containing interface definitions and theNotificationSystem
.trac/notification/mail.py
containing any email specific functionality likeSmtpEmailSender
andSendmailEmailSender
.trac/notification/compat.py
containing theNotify
/NotifyEmail
base classes. (After #3517 these andTicketNotifyEmail
would only remain for backward compatibility and could be deprecated and removed later.)
For backwards compatibility these will also be imported in trac/notification/__init__.py
.
I'd also like to extract some useful pieces from NotifyEmail
and TicketNotifyEmail
into trac/notification/mail.py
, so we can reuse them later.
The proposed changes are in log:psuter@advanced-notification-preliminary-refactorings.
Change History (2)
comment:1 by , 9 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
Committed to trunk in [13433].