Opened 8 years ago
Closed 8 years ago
Last modified 6 years ago
#11849 closed enhancement (fixed)
Move some repository-related configuration options
|Reported by:||Ryan J Ollos||Owned by:||Ryan J Ollos|
Moved repository-related configuration options to new sections.
Description (last modified by )
It might make sense to move the following configuration options:
This was previously discussed starting in comment:1:ticket:11703.
Change History (12)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
|Milestone:||next-dev-1.1.x → 1.1.5|
|Status:||new → assigned|
comment:3 by , 8 years ago
|Milestone:||1.1.5 → 1.1.4|
comment:4 by , 8 years ago
|Release Notes:||modified (diff)|
|Status:||assigned → closed|
Committed to trunk in [13846:13847].
comment:5 by , 8 years ago
|API Changes:||modified (diff)|
follow-up: 7 comment:6 by , 8 years ago
Just got hit by this on one system…
After an upgrade, I ended up with:
[versioncontrol] default_repository_type =
and the corresponding "
'' version control system not supported" error, with no access to any svn repositories possible.
I think that as we used to have
svn as an implicit default, my
config.get('trac', 'repository_type') was
''… Now if we're going to write that unconditionally, we end up with the above excert in the trac.ini, and the default from the option doesn't kick in.
So maybe we can only write that entry if it has an non-empty value?
comment:7 by , 8 years ago
comment:8 by , 8 years ago
comment:9 by , 7 years ago
Tests added in r14152 weren't being executed when
upgrade package tests executed. Fixed in [14862:14863].
comment:10 by , 7 years ago
I think we could use
EnvironmentStub.reset_db_and_disk instead of
env.shutdown in .
diff --git a/trac/upgrades/tests/db39.py b/trac/upgrades/tests/db39.py index 4269a4a..40e151a 100644
a b class UpgradeTestCase(unittest.TestCase): 38 38 RepositoryManager(self.env) 39 39 40 40 def tearDown(self): 41 self.env.shutdown() 42 shutil.rmtree(self.env.path) 41 self.env.reset_db_and_disk() 43 42 44 43 def test_saves_backup(self): 45 44 """Backup file is saved during upgrade."""
comment:11 by , 7 years ago
Thanks, fixed in .
comment:12 by , 6 years ago
Proposed changes in log:rjollos.git:t11849.