Replace underscores with whitespace when creating action label from action name

[Ryan J Ollos]

Consider a workflow action such as the following:

may_reassign = new,assigned,accepted,reopened -> assigned
may_reassign.operations = may_set_owner
may_reassign.permissions = TICKET_MODIFY 
may_reassign.set_owner =

If I want the action name to look nice, I must add another attribute:

may_reassign.name = may reassign

What would be the downside to doing a simple replacement?

trac/ticket/default_workflow.py

@@ -67 +67 @@
     for action, attributes in actions.items():
         # Default the 'name' attribute to the name used in the ini file
         if 'name' not in attributes:
-            attributes['name'] = action
+            attributes['name'] = action.replace("_", " ")
         # If not specified, an action is not the default.
         attributes['default'] = int(attributes.get('default', 0))
         # If operations are not specified, that means no operations

The only downside I can think of is when the user really wants an underscore in the name, but I guess that to be a rather infrequent occurrence.

The same replacement could be applied to TracTicketsCustomFields field name.

Speaking of which, it's a bit confusing that the attribute label is used for TracTicketsCustomFields, whereas name is used for TracWorkflow, considering the attribute do the same thing.

Anyway, those are just small things and not too important.