Raw revision of cached git repository in search view

[Jun Omae]

If searching changesets in cached git repository, the revisions are displayed with no changes. The issue doesn't occur if mercurial because search system requires revision table and mercurial connector doesn't support cache.

Both 0.12.x with ​th:GitPlugin and 1.0.x have this issue.

We should show shortened revisions in search view.

Patch for 1.0-stable:

trac/versioncontrol/web_ui/changeset.py

@@ -1128 +1128 @@
                     SELECT repos, rev, time, author, message
                     FROM revision WHERE """ + sql,
                     args):
-                try:
-                    rev = int(rev)
-                except ValueError:
-                    pass
                 repos = repositories.get(id)
                 if not repos:
                     continue # revisions for a no longer active repository
                 cset = repos.resource.child('changeset', rev)
                 if 'CHANGESET_VIEW' in req.perm(cset):
+                    try:
+                        drev = repos.display_rev(rev)
+                    except NoSuchChangeset:
+                        continue
                     yield (req.href.changeset(rev, repos.reponame or None),
-                           '[%s]: %s' % (rev, shorten_line(log)),
+                           '[%s]: %s' % (drev, shorten_line(log)),
                            from_utimestamp(ts), author,
                            shorten_result(log, terms))