Move the repository_sync_per_request configuration option to the repositories section

[Ryan J Ollos]

As described in comment:1:ticket:11703, move the [trac] repository_sync_per_request configuration option to the [repositories] section:

[repositories]
<name>.sync_per_request = true/false

and similarly add an attribute for repositories defined through DbRepostioryProvider. Also, allow the option to be configurable from the repositories web admin page. This might help with configuration issues like the one reported in #11767.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11776.1. TracRepositoryAdmin page modified to document these changes in 1.1/TracRepositoryAdmin@2.

[anonymous]

Looking good. +1

[Ryan J Ollos]

Changes for #11703 will need to be committed before these changes. Committing these changes first leads to test failures since there's no way to define explicit synchronization for the repository defined in [trac] repository_dir, and some tests in trac/versioncontrol/tests/functional.py depend on explicit synchronization.

[Jun Omae]

I just confirmed rjollos.git@t11776.1.

1. Even if sync_per_request is 0, sync is executed by each request.
2. Synchronized '(default)' repository … is not logged even if sync is successful.
3. If Sync on every request is Not recommended, I think the option should be disabled for new repository by default. Adding a large repository from repository admin panel, a user would have a long wait for next request.

trac/versioncontrol/api.py

@@ -221 +221 @@
                 "INSERT INTO repository (id, name, value) VALUES (%s, %s, %s)",
                 [(id, 'dir', dir),
                  (id, 'type', type_ or ''),
-                 (id, 'sync_per_request', '1')])
+                 (id, 'sync_per_request', '0')])
         rm.reload_repositories()
 
     def add_alias(self, reponame, target):
@@ -336 +336 @@
         from trac.web.chrome import Chrome, add_warning
         if handler is not Chrome(self.env):
             for repo_info in self.get_all_repositories().values():
-                if not repo_info.get('sync_per_request'):
+                if not as_bool(repo_info.get('sync_per_request')):
                     continue
                 start = time.time()
                 repo_name = repo_info['name'] or '(default)'
                 try:
                     repo = self.get_repository(repo_info['name'])
                     repo.sync()
-                    continue
                 except TracError as e:
                     add_warning(req,
                         _("Can't synchronize with repository \"%(name)s\" "

[Jun Omae]

4. We should use i18n:msg for span of new hint.

trac/versioncontrol/templates/admin_repositories.html

@@ -86 +86 @@
                           disabled="${not info.editable or None}" />
               Sync on every request
             </label>
-            <span class="hint">Not recommended. See <a href="${href.wiki('TracRepositoryAdmin') + '#ExplicitSync'}">explicit synchronization</a> for more info.</span>
+            <span class="hint" i18n:msg="">Not recommended. See <a href="${href.wiki('TracRepositoryAdmin') + '#ExplicitSync'}">explicit synchronization</a> for more info.</span>
           </div>
           <div class="field">
             <label><input type="checkbox" name="hidden" value="1" checked="${info.hidden or None}"

[Ryan J Ollos]

Thanks for the review and patches. Committed to trunk in [13393:13394].