Edgewall Software

Changes between Initial Version and Version 1 of Ticket #11776, comment 6


Ignore:
Timestamp:
Nov 19, 2014, 9:56:13 AM (7 years ago)
Author:
Jun Omae

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11776, comment 6

    initial v1  
    33 1. Even if `sync_per_request` is `0`, sync is executed by each request.
    44 2. //Synchronized '(default)' repository ...// is not logged even if sync is successful.
     5 3. If //Sync on every request// is //Not recommended//, I think the option should be disabled for new repository by default. Adding a large repository from repository admin panel, a user would have a long wait for next request.
     6
    57{{{#!diff
    68diff --git a/trac/versioncontrol/api.py b/trac/versioncontrol/api.py
    7 index 9b4e28e..99a3426 100644
     9index 9b4e28e..0b33b6b 100644
    810--- a/trac/versioncontrol/api.py
    911+++ b/trac/versioncontrol/api.py
     12@@ -221,7 +221,7 @@ class DbRepositoryProvider(Component):
     13                 "INSERT INTO repository (id, name, value) VALUES (%s, %s, %s)",
     14                 [(id, 'dir', dir),
     15                  (id, 'type', type_ or ''),
     16-                 (id, 'sync_per_request', '1')])
     17+                 (id, 'sync_per_request', '0')])
     18         rm.reload_repositories()
     19
     20     def add_alias(self, reponame, target):
    1021@@ -336,14 +336,13 @@ class RepositoryManager(Component):
    1122         from trac.web.chrome import Chrome, add_warning
     
    2536                         _("Can't synchronize with repository \"%(name)s\" "
    2637}}}
    27  3. If //Sync on every request// is //Not recommended//, I think the option should be disabled for new repository by default. Adding a large repository from repository admin panel, a user would have a long wait for next request.