Edgewall Software

Changes between Initial Version and Version 21 of Ticket #11773


Ignore:
Timestamp:
Feb 25, 2015, 10:59:35 PM (8 years ago)
Author:
Ryan J Ollos
Comment:

Splitting the args may be implemnetd as described in comment:13:ticket:8168, which will result in a refactoring of the changes from #10562. IMAGE_MACRO_TEST_CASES will be extended to cover the data scheme: tags/trac-1.0.4/trac/wiki/tests/macros.py@:56#L52​. The Image macro documentation will be extended.

Jun, do you still have any concerns about using the data scheme with the Image macro?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11773

    • Property Status new → assigned
    • Property Cc leho@… added
    • Property Summary Image links based on RFC2397 not supported → [PATCH] Image links based on RFC2397 not supported
    • Property Version → 1.0.1
    • Property Milestone → 1.0.5
    • Property Owner set to Ryan J Ollos

  • Ticket #11773 – Description

    initial v21  
    1 Directly included images in this RFC format http://tools.ietf.org/html/rfc2397 aren't supported. They don't work in {{{[[Image()]]}}} macro nor in {{{#!html}}}
     1Directly included images in the rfc:2397 format isn't supported. They don't work in {{{[[Image()]]}}} macro nor in {{{#!html}}}
    22processor.
    33
    4 {{{data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAQMAAAC2MCouAAAAA1BMVEXLQ0MOAUiXAAAAC0lEQVQIHWMYYQAAAPAAASEIRrcAAAAASUVORK5CYII=}}}
     4{{{
     5data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAQMAAAC2MCouAAAAA1BMVEXLQ0MOAUiXAAAAC0lE
     6QVQIHWMYYQAAAPAAASEIRrcAAAAASUVORK5CYII=
     7}}}
    58
    6 See also #8168 which comes up again, as there is a comma in the string which can't be encoded as %2c, otherwise fix would be easy.
     9See also #8168 which comes up again, as there is a comma in the string which can't be encoded as `%2c`, otherwise fix would be easy.
    710
    8 Fix for "data:" is easy, simply handle it like http:, but the comma is a problem again. Proper argument splitting is required.
     11Fix for `data:` is easy, simply handle it like `http:`, but the comma is a problem again. Proper argument splitting is required.
    912
    10 {{{
    11 #!diff
     13{{{#!diff
    1214--- macros.py_orig      2014-10-04 21:33:12.000000000 +0200
    1315+++ macros.py   2014-10-04 21:51:16.000000000 +0200

  • Ticket #11773 – Release Notes

    initial v21  
     1The [rfc:2397 data] URL scheme can be used with the [WikiMacros#Image-macro Image macro].