Edgewall Software

Opened 10 years ago

Closed 10 years ago

#11733 closed defect (fixed)

UndefinedError when an error occurs if [project] admin_trac_url is empty — at Version 2

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 0.12.6
Component: general Version: 0.12-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed raising UndefinedError if an internal error occurs and disabling report buttons while accessing by non administrator.

API Changes:
Internal Changes:

Description

[project] admin_trac_url in TracIni says;

Base URL of a Trac instance where errors in this Trac should be reported. This can be an absolute or relative URL, or '.' to reference this Trac instance. An empty value will disable the reporting buttons. (since 0.11.3)

However, stack trace is shown instead of disabling the reporting buttons. The issue occurs on both 0.12-stable and 1.0-stable. 

...
  File "home/jun66j5/venv/py24-0.12/lib/python2.4/site-packages/genshi/template/eval.py", line 178, in evaluate
  File "/home/jun66j5/src/tracdev/git/trac/templates/error.html", line 102, in <Expression u'project.admin_href.newticket()'>
    <form class="newticket" method="get" action="${project.admin_href.newticket()}#">
  File "home/jun66j5/venv/py24-0.12/lib/python2.4/site-packages/genshi/template/eval.py", line 277, in _die
UndefinedError: None has no member named "newticket"

Originally reported at ​th:#9193 and ​th:comment:4:ticket:9988.

Change History (2)

comment:1 by Jun Omae, 10 years ago

Milestone: next-minor-0.12.x → 0.12.6
Owner: set to Jun Omae
Status: new → assigned

Proposed changes: jomae.git@t11733_0.12 and jomae.git@t11733_1.0.

comment:2 by Jun Omae, 10 years ago

Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Committed in [13101] and merged in [13102] and [13103].

Note: See TracTickets for help on using tickets.