Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11689 closed defect (fixed)

Anonymous is not translated in ticket workflow hint

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: ticket system Version:
Severity: normal Keywords: translation
Cc: Branch:
Release Notes:

Anonymous and (none) are translated in the ticket workflow action hints.

API Changes:
Internal Changes:

Description

As mentioned in comment:1:ticket:11474, anonymous is not translated in the ticket workflow action hint. However, it is property translated in the ticket properties box.

With the proposed changes,

Attachments (1)

t11689-render_ticket_action_control.diff (2.3 KB ) - added by Jun Omae 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Ryan J Ollos, 6 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Committed to 1.0-stable in [13000], merged to trunk in [13001].

comment:2 by Ryan J Ollos, 6 years ago

One additional related fix in [13032], merged in [13033].

Version 0, edited 6 years ago by Ryan J Ollos (next)

in reply to:  2 comment:3 by Jun Omae, 6 years ago

One additional related fix in [13032], merged in [13033].

I think that the space character in suffix of "from invalid state " is intentional.

If .operations of the aciton has multiple operations in a workflow, it generates multiple control and concatinates at tags/trac-1.0.1/trac/ticket/default_workflow.py#L329.

I think it would be good to concatinate with space at the end rather than generating a control ended with a space, attachment:t11689-render_ticket_action_control.diff.

comment:4 by Ryan J Ollos, 6 years ago

Thanks, that looks good. It will eliminate 1 message from the catalog that differs by only a single white-space.

Committed in [13038], merged in [13039]. New message extractions in [13040] and [13042].

comment:5 by Ryan J Ollos, 6 years ago

It looks like we could refactor [13038] in milestone:1.0.3 with:

  • trac/ticket/default_workflow.py

    diff --git a/trac/ticket/default_workflow.py b/trac/ticket/default_workflow.py
    index c735d02..11353d5 100644
    a b from trac.env import IEnvironmentSetupParticipant  
    3030from trac.perm import PermissionSystem
    3131from trac.ticket.api import ITicketActionController, TicketSystem
    3232from trac.ticket.model import Resolution
     33from trac.util.presentation import separated
    3334from trac.util.text import obfuscate_email_address
    3435from trac.util.translation import _, tag_, cleandoc_
    3536from trac.web.chrome import Chrome, add_script, add_script_data
    Read TracWorkflow for more information (don't forget to 'wik  
    346347        else:
    347348            if status != '*':
    348349                hints.append(_("Next status will be '%(name)s'", name=status))
    349         return (this_action['name'],
    350                 tag((' ' if i else None, c) for i, c in enumerate(control)),
     350        return (this_action['name'], tag(separated(control, ' ')),
    351351                '. '.join(hints) + '.' if hints else '')
    352352
    353353    def get_ticket_changes(self, req, ticket, action):

comment:6 by Ryan J Ollos, 6 years ago

Change from comment:5 committed to 1.0-stable (1.0.3dev) in [13164], merged to trunk in [13165].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.