Milestone edit page should more clearly show when milestone doesn't exist

[Ryan J Ollos]

When navigating from the Add new milestone button on the Roadmap page the path will be /milestone?action=new and the user should have a good idea that the milestone does not yet exist (although it might be less clear when &name=milestoneX is appended to the path resulting in the milestone name input having text).

In the case that a link is followed to a non-existing milestone the path will be /milestone/milestoneX and it might be less clear that the milestone does not yet exist. We could give a clear indicator in this case:

The patch would be simple, and would not add a notice for the case that was first described, when the user follows the Add new milestone link.

trac/ticket/roadmap.py

@@ -860 +860 @@
             data['milestone_groups'] = group_milestones(milestones,
                 'TICKET_ADMIN' in req.perm)
         else:
+            if milestone.name:
+                add_notice(req, _("Milestone %(name)s does not exist. You can"
+                                  " create it here.", name=milestone.name))
             req.perm(milestone.resource).require('MILESTONE_CREATE')
 
         chrome = Chrome(self.env)