Acknowledgement message is not localized when changing language

[Ryan J Ollos]

When changing languages through the preferences admin page, the notification message is displayed in the previous language:

English → French

French → English

[Jun Omae]

Ad-hoc patch.

trac/prefs/web_ui.py

@@ -27 +27 @@
 from trac.core import *
 from trac.prefs.api import IPreferencePanelProvider
 from trac.util.datefmt import all_timezones, get_timezone, localtz
-from trac.util.translation import _, get_available_locales
-from trac.web import HTTPNotFound, IRequestHandler
+from trac.util.translation import _, deactivate, get_available_locales, \
+                                  make_activable
+from trac.web.api import HTTPNotFound, IRequestHandler
+from trac.web.main import RequestDispatcher
 from trac.web.chrome import add_notice, add_stylesheet, \
                             INavigationContributor, ITemplateProvider
 
@@ -148 +150 @@
         req.send_no_content()
 
     def _do_save(self, req):
+        language = req.session.get('language')
         for field in self._form_fields:
             val = req.args.get(field, '').strip()
             if val:
@@ -163 +166 @@
             elif field in req.session and (field in req.args or
                                            field + '_cb' in req.args):
                 del req.session[field]
+        if req.session.get('language') != language:
+            # reactivate translations with new language setting when changed
+            locale = RequestDispatcher(self.env)._get_locale(req)
+            deactivate()
+            make_activable(lambda: locale, self.env.path)
         add_notice(req, _('Your preferences have been saved.'))
 
     def _do_load(self, req):

[Jun Omae]

I've revised the patch and added functional tests, jomae.git@t11515.

[Ryan J Ollos]

Thanks for the quick fix. The changes work well for me.

[Jun Omae]

Thanks for testing. I'll push the changes later.

[Jun Omae]

Committed in [12578] and merged to trunk in [12579].

[Jun Omae]

RegressionTestTicket11515 intermittently fails on autobuilds. See comment:19:ticket:11813.

[Jun Omae]

Fixed the failure in [13299] and merged to trunk in [13300].