Edgewall Software
Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#11471 closed enhancement (fixed)

Summary and Reporter fields should span width of Description text area

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Milestone: 1.0.2
Component: ticket system Version:
Severity: normal Keywords: css
Cc:
Release Notes:

Improved layout of elements in the ticket properties box. For Trac 1.1.2, the textarea custom fields now span the width of the properties box and the cols option is removed.

API Changes:

Description

There is unused space to the right of the Summary and Reporter fields in the Properties fieldset. The additional space would be useful for the Summary and improve the visual layout. See also #11106.

Attachments (9)

before.png (16.6 KB ) - added by Ryan J Ollos 5 years ago.
after.png (16.2 KB ) - added by Ryan J Ollos 5 years ago.
before2.png (15.1 KB ) - added by Ryan J Ollos 5 years ago.
after2.png (15.2 KB ) - added by Ryan J Ollos 5 years ago.
before3.png (17.7 KB ) - added by Ryan J Ollos 5 years ago.
after3.png (17.7 KB ) - added by Ryan J Ollos 5 years ago.
wrap-radiobuttons.png (24.6 KB ) - added by Ryan J Ollos 5 years ago.
TicketProperties.png (28.7 KB ) - added by Ryan J Ollos 5 years ago.
TicketProperties-before.png (28.6 KB ) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (26)

comment:1 Changed 5 years ago by Ryan J Ollos

Status: newassigned

Changed 5 years ago by Ryan J Ollos

Attachment: before.png added

Changed 5 years ago by Ryan J Ollos

Attachment: after.png added

Changed 5 years ago by Ryan J Ollos

Attachment: before2.png added

Changed 5 years ago by Ryan J Ollos

Attachment: after2.png added

Changed 5 years ago by Ryan J Ollos

Attachment: before3.png added

Changed 5 years ago by Ryan J Ollos

Attachment: after3.png added

comment:2 Changed 5 years ago by Ryan J Ollos

As usual this expanded into a series of changes.

  1. Here is the before and after with the Summary and Reporter expanded to fit the width of the properties box.

  1. Other inputs can also use more of the available width.

  1. The textareas could span the width of the the enclosing td as well. This overrides the cols parameter. We could keep the cols parameter functional, but I wonder what value it has since the textarea is always a fullrow.

The changes described in (3) are more suitable for the trunk. I feel good about change (1), but I'm less certain about (2) and (3).

Proposed changes can be found in log:rjollos.git:t11471.

comment:3 Changed 5 years ago by Jun Omae

I think that

#properties table td input,

should be

#properties table td input[type=text],

e.g. radio button and checkbox.

Last edited 5 years ago by Jun Omae (previous) (diff)

comment:4 Changed 5 years ago by Ryan J Ollos

Thanks, I forgot to test those two cases. Changes have been added to log:rjollos.git:t11471.

comment:5 in reply to:  2 Changed 5 years ago by Jun Omae

  1. Here is the before and after with the Summary and Reporter expanded to fit the width of the properties box.

+1, agreed. I've applied the same to custom Trac instances which our company serves.

  1. Other inputs can also use more of the available width.

If a milestone has very long name, the text field would be too wide.

In the Trac instances, I've applied like this.

#properties table { table-layout: fixed }
#properties table td select { max-width: 100% }

See [f0df2bed/jomae.git].

  1. The textareas could span the width of the the enclosing td as well. This overrides the cols parameter. We could keep the cols parameter functional, but I wonder what value it has since the textarea is always a fullrow.

+1 for trunk.

Last edited 5 years ago by Jun Omae (previous) (diff)

Changed 5 years ago by Ryan J Ollos

Attachment: wrap-radiobuttons.png added

comment:6 Changed 5 years ago by Ryan J Ollos

I like the changes that limit the width of the selects, but the second header column doesn't seem to be the right width after applying those changes (it should be 20%, but it's much wider even if the custom field with the long label is removed).

Other changes for consideration:

  • Wrap the label's content if they become too wide.
  • Wrap the radio buttons if there are too many entries for the width.

Revised changes in log:rjollos.git:t11471.2.

comment:7 in reply to:  6 Changed 5 years ago by Jun Omae

  • Wrap the radio buttons if there are too many entries for the width.

It would be good to add margin between labels.

 #properties table td.col1 label,
-#properties table td.col2 label { float: left; }
+#properties table td.col2 label { float: left; margin-right: 0.5em }
 #properties table td select { max-width: 100% }

comment:8 Changed 5 years ago by Ryan J Ollos

The right-margin on the labels is a good addition. I'm still not sure what to do about the widths of the ths and tds. The image in comment:6 shows that the widths are 146px | 194px | 194px | 193px, but should be 20% | 30% | 20% | 30% = 145px | 218px | 145px | 218px.

Changed 5 years ago by Ryan J Ollos

Attachment: TicketProperties.png added

comment:9 Changed 5 years ago by Ryan J Ollos

The issue seems to be that with table-layout: fixed the width of the cells in the first row are applied to all of the rows, and the colspan forces columns 2, 3 and 4 to the same width (SO:8848758).

At first I tried adding the following as the first row,

<tr>
  <th class="col1"></th><td class="col1"></td>
  <th class="col2"></th><td class="col2"></td>
</tr>

which works except that the empty row takes up a small bit of vertical space. SO:10712993 seems to have a better suggestion of using col elements. The result looks nice as far as I can see,

Here if the before, for comparison:

Latest changes can be found in log:rjollos.git:t11471.2. I've tested with Chrome 31 / Firefox 26 / Opera 12.16 on Ubuntu 13.04; IE 11 / Chrome 32 / Firefox 24 (Waterfox) on Win 7.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

Changed 5 years ago by Ryan J Ollos

Attachment: TicketProperties-before.png added

comment:10 Changed 5 years ago by Ryan J Ollos

Release Notes: modified (diff)

In [12512] on trunk: textarea custom fields now span the width of the properties box and cols field is removed. Documentation updated.

comment:11 Changed 5 years ago by Ryan J Ollos

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [12513:12514] and merged to trunk in [12515:12516].

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:12 Changed 5 years ago by Ryan J Ollos

[12512] introduced a failing unit test, fixed in [12517].

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:13 Changed 5 years ago by Ryan J Ollos

Refactoring in [12520], merged to trunk in [12521].

comment:14 Changed 4 years ago by anonymous

I built [13100] today and the Summary field is being displayed showing about 21 characters when creating a new ticket or in the Modify Ticket area. This needs to be changed. The Report field has the same problem.

comment:15 in reply to:  14 ; Changed 4 years ago by Ryan J Ollos

Replying to anonymous:

I built [13100] today and the Summary field is being displayed showing about 21 characters when creating a new ticket or in the Modify Ticket area. This needs to be changed. The Report field has the same problem.

You need to do a forced refresh of your browser or perhaps you've not refreshed your static resources.

comment:16 in reply to:  15 ; Changed 4 years ago by anonymous

Replying to rjollos:

Replying to anonymous:

I built [13100] today and the Summary field is being displayed showing about 21 characters when creating a new ticket or in the Modify Ticket area. This needs to be changed. The Report field has the same problem.

You need to do a forced refresh of your browser or perhaps you've not refreshed your static resources.

I am still seeing the same results after a forced refresh. check the new line 230 in this file.

comment:18 in reply to:  16 Changed 4 years ago by Ryan J Ollos

Replying to anonymous:

I am still seeing the same results after a forced refresh. check the new line 230 in this file.

The size attribute is no longer necessary because we have a rule in the stylesheet that makes the text box span the width of the row. You likely don't have the new stylesheet loaded into your browser. As already mentioned, if you are running a web server you need to refresh your static assets and restart your web server.

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.