set_owner_to_self should use author from form or prefs

[Ryan J Ollos]

When changing a ticket the author field is populated from prefs, that author field value can be replaced by the user, and the value of the author field is used as the ticket change author. However, when accepting a ticket, the set_owner_to_self action does not use the author field when consider who the ticket should be assigned to.

The following patch has been lightly tested, but may be a starting point in aligning the behavior of the workflow with the rest of the ticket form.

trac/ticket/default_workflow.py

@@ -29 +29 @@
 from trac.perm import PermissionSystem
 from trac.ticket.api import ITicketActionController, TicketSystem
 from trac.ticket.model import Resolution
+from trac.util import get_reporter_id
 from trac.util.text import obfuscate_email_address
 from trac.util.translation import _, tag_, cleandoc_
 from trac.web.chrome import Chrome, add_script, add_script_data
@@ -285 +286 @@
                                "%(current_owner)s to the selected user",
                                current_owner=current_owner))
         elif 'set_owner_to_self' in operations and \
-                ticket._old.get('owner', ticket['owner']) != req.authname:
+                ticket._old.get('owner', ticket['owner']) != \
+                        get_reporter_id(req, 'author'):
             hints.append(_("The owner will be changed from %(current_owner)s "
                            "to %(authname)s", current_owner=current_owner,
-                           authname=req.authname))
+                           authname=get_reporter_id(req, 'author')))
         if 'set_resolution' in operations:
             if 'set_resolution' in this_action:
                 resolutions = [x.strip() for x in
@@ -364 +366 @@
                     newowner = newowner[0]
                 updated['owner'] = newowner
             elif operation == 'set_owner_to_self':
-                updated['owner'] = req.authname
+                updated['owner'] = get_reporter_id(req, 'author')
             elif operation == 'del_resolution':
                 updated['resolution'] = ''
             elif operation == 'set_resolution':