Edgewall Software

Changes between Version 1 and Version 2 of Ticket #11377, comment 7


Ignore:
Timestamp:
Feb 18, 2014, 5:06:36 AM (9 years ago)
Author:
Jun Omae

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11377, comment 7

    v1 v2  
    33Indeed. But I think `ticket_change_deleted` is better cause of `Ticket.delete_change()`. Proposed changes can be found in [log:jomae.git@t11377].
    44
    5 
    65> In the case of deleting a comment though, we are really deleting a //change//, which includes ticket properties: `Ticket.delete_change` is called by `TicketDeleter`. When editing a comment, `Ticket.modify_comment` is called, but perhaps we should make the interface more generic for cases that properties might be edited through a plugin. So should the methods be `ticket_change_modified` and `ticket_change_deleted`?
    76
    8 No. The methods doesn't provide a way to edit the properties of ticket. The interface is a post-hook is called after a ticket is changed. We should add or improve an interface for the edit of properties, e.g. `ITicketManipulator.prepare_ticket()` and #11477.
     7No. The methods doesn't provide a way to edit the properties of ticket. The interface is a post-hook is called after a ticket is changed. If the enhancement is reasonable, we should add or improve an interface for the edit of properties, e.g. `ITicketManipulator.prepare_ticket()` and #11477.