Edgewall Software
Modify

Opened 9 years ago

Last modified 3 years ago

#11374 new defect

Image macro doesn't display image containing a colon

Reported by: Ryan J Ollos Owned by:
Priority: normal Milestone: next-stable-1.4.x
Component: wiki system Version:
Severity: normal Keywords: imagemacro
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

For example, see the attachment:

[[Image(2013-11-19_19:34:53.png​)]]

No image "53.png" attached to 2013-11-19_19:34

Attachments (1)

2013-11-19_19:34:53.png (33.1 KB ) - added by Ryan J Ollos 9 years ago.

Download all attachments as: .zip

Change History (7)

by Ryan J Ollos, 9 years ago

Attachment: 2013-11-19_19:34:53.png added

comment:1 by Ryan J Ollos, 9 years ago

This is not too surprising since the colon is used as the realm and resource separator, but maybe we should at least allow an escape character to be used like on the filesystem 2013-11-19_19\:34\:53.png. I only noticed because the example shown is a truncated version of the default filename that is created by the Screenshot tool on Ubuntu.

comment:2 by Jun Omae, 9 years ago

#10562 was fixed to show image for page name with colon characters and allows to enclose quote characters the page name.

[[Image("page:fr":image.png)]]

comment:3 by Ryan J Ollos, 9 years ago

Thanks, I was looking for a ticket because I thought the issue sounded familiar, and #10562 is what I was barely remembering.

Version 0, edited 9 years ago by Ryan J Ollos (next)

comment:4 by Ryan J Ollos, 8 years ago

I tried resolving this case in [13787] when fixing #8168, however I couldn't come up with a solution to both. Outer quotes are stripped before splitting at the colon to handle the case of a quoted URI branches/1.0-stable/trac/wiki/macros.py@13793:#L594 (e.g. "http://trac.edgewall.org/attachment/ticket/13374/file" or "data:image/png;base64,iVBORw0KGgoAA"). However, in a case like [[Image("page:fr":"ima:ge.png")]] we would not want to strip off the outer quotes.

comment:5 by Ryan J Ollos, 6 years ago

Milestone: next-stable-1.0.xnext-stable-1.2.x

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

comment:6 by Ryan J Ollos, 3 years ago

Milestone: next-stable-1.2.xnext-stable-1.4.x

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.