Changes between Version 2 and Version 3 of Ticket #11309, comment 4
- Timestamp:
- Oct 2, 2013, 8:37:42 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #11309, comment 4
v2 v3 1 Side note: In [8027], `close_fds` was moved from `trac.tests.functional.compat` to `trac.util.compat`. There are two remaining uses of `trac.tests.functional.compat` that I'll modify to import from `trac.util.compat`. I suppose the unused import of `close_fds` in `trac.tests.functional.compat` should be left in place in case any plugins are using it, but maybe it should be removed on the trunk now or eventually. I also searched the codebase for `close_fds`, for cases were it could be utilized from `trac.tests.functional.compat` due to a wildcard import or similar, and found no additional cases that it is used.1 Side note: In [8027], `close_fds` was moved from `trac.tests.functional.compat` to `trac.util.compat`. There are two remaining uses of `trac.tests.functional.compat` that I'll modify to import from `trac.util.compat`. I suppose the unused import of `close_fds` in `trac.tests.functional.compat` should be left in place in case any plugins are using it, but maybe it should be removed on the trunk now or eventually. I also searched the codebase for `close_fds`, for cases were it could be utilized from `trac.tests.functional.compat` due to a wildcard import or similar, and found no additional places that it is used. 2 2 3 3 {{{#!sh
