Add an inlinelinkbutton class

[chris.nelson.1022@…]

The buttons plugins add to ticket pages (Create, Delete, etc.) have a range of plugin-specific styles. It would be nice to unify them. Some plugins use a button, others use a link styled as a button.

The existing inline buttons style had a relative font size but depending on where the button was in the page, it could have a different appearance. This patch makes the text size consistent.

The new inlinelinkbutton style makes links with that style look like inline buttons.

[Chris.Nelson@…]

Patch to make inline buttons consistent, add inlinelinkbutton style

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to Chris.Nelson@…:

The buttons plugins add to ticket pages (Create, Delete, etc.) have a range of plugin-specific styles.

Plugins provided with Trac, tracopt.ticket.clone and tracopt.ticket.deleter, add input elements for the buttons, so it looks like the Clone and Delete buttons should be okay (and even for Trac < 0.12, the ​th:TicketDeletePlugin appears to add an input element within the div.inlinebuttons). You mentioned Create, and I don't think I've seen a plugin that adds a Create button.

Which other plugins on Trac add link elements?

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Which other plugins on Trac add link elements?

Sorry, I meant Trac and/or Trac-Hacks.

[Chris.Nelson@…]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Replying to Chris.Nelson@…:

The buttons plugins add to ticket pages (Create, Delete, etc.) have a range of plugin-specific styles.

Plugins provided with Trac, tracopt.ticket.clone and tracopt.ticket.deleter, add input elements for the buttons, so it looks like the Clone and Delete buttons should be okay (and even for Trac < 0.12, the ​th:TicketDeletePlugin appears to add an input element within the div.inlinebuttons). You mentioned Create, and I don't think I've seen a plugin that adds a Create button.

Which other plugins on Trac add link elements?

I believe Subtickets plugin does. I know my ​TicketCreateButtonsPlugin plugin does.

[Ryan J Ollos]

The proposed change in [f22fa670/rjollos.git#file0] would allow adding the inlinebuttons class to a div or span that wraps a link. Would that be sufficient for your needs?

[Chris.Nelson@…]

Replying to rjollos:

The proposed change in [f22fa670/rjollos.git#file0] would allow adding the inlinebuttons class to a div or span that wraps a link. Would that be sufficient for your needs?

I suspect it is inadequate because it leaves the text with a relative size so depending on the context, the buttons may have different sizes. We have a Trac 1.0 version of this but I am out of the office. I can try to attach it when I return.

[Jun Omae]

Replying to Chris.Nelson@…:

Replying to rjollos:

The proposed change in [f22fa670/rjollos.git#file0] would allow adding the inlinebuttons class to a div or span that wraps a link. Would that be sufficient for your needs?

I suspect it is inadequate because it leaves the text with a relative size so depending on the context, the buttons may have different sizes. We have a Trac 1.0 version of this but I am out of the office. I can try to attach it when I return.

I've commented about tweaking style of the link buttons. See comment:11:ticket:6573.

[Ryan J Ollos]

Replying to Chris.Nelson@…:

I believe ​SubticketsPlugin does. I know my ​TicketCreateButtonsPlugin plugin does.

I did some testing.

​TicketCreateButtons adds input elements: ​browser:/ticketcreatebuttonsplugin/0.11/ticketCreateButtons/ticketCreateButtons.py@9441:114-115#L111. The inlinebuttons styling is applied to those.

I don't see any "actionable" links created by ​SubticketsPlugin.

The ​TicketCreateButtonsPlugin button are smaller than the buttons below the description, but that might be better fixed with some styling for ​TicketCreateButtonsPlugin. That would be the only open action item I see in this ticket after the changes in #6573 are committed.

[Chris.Nelson@…]

Replying to rjollos:

Replying to Chris.Nelson@…:

I believe ​SubticketsPlugin does. I know my ​TicketCreateButtonsPlugin plugin does.

I did some testing.

Empirical evidence is always best!

​TicketCreateButtons adds input elements: ​browser:/ticketcreatebuttonsplugin/0.11/ticketCreateButtons/ticketCreateButtons.py@9441:114-115#L111. The inlinebuttons styling is applied to those.

I don't see any "actionable" links created by ​SubticketsPlugin.

It has a button to create children. I'll attach an example.

The ​TicketCreateButtonsPlugin button are smaller than the buttons below the description, but that might be better fixed with some styling for ​TicketCreateButtonsPlugin. That would be the only open action item I see in this ticket after the changes in #6573 are committed.

Well, I'd argue that it should be trivial to create buttons like Trac does by using its style, not requiring any overrides or customization. But it's not worth a lot to me.

[Chris.Nelson@…]

Example of Subtickets button to create children

[Chris.Nelson@…]

Subtickets plugin in 0.11.6:

[Ryan J Ollos]

Milestone renamed

[Ryan J Ollos]

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

[Ryan J Ollos]

Milestone renamed