Good idea!
Suggesting the following improvement:
-
|
|
|
|
| 226 | 226 | this_action = self.actions[action] |
| 227 | 227 | status = this_action['newstate'] |
| 228 | 228 | operations = this_action['operations'] |
| 229 | | current_owner = ticket._old.get('owner', ticket['owner'] or '(none)') |
| | 229 | current_owner_or_empty = ticket._old.get('owner', ticket['owner']) |
| | 230 | current_owner = current_owner_or_empty or '(none)' |
| 230 | 231 | if not (Chrome(self.env).show_email_addresses |
| 231 | 232 | or 'EMAIL_VIEW' in req.perm(ticket.resource)): |
| 232 | 233 | format_user = obfuscate_email_address |
| … |
… |
|
| 323 | 324 | control.append(_('as %(status)s ', |
| 324 | 325 | status= ticket._old.get('status', |
| 325 | 326 | ticket['status']))) |
| | 327 | hints.append(_("The owner will remain %(current_owner)s", |
| | 328 | current_owner=current_owner) |
| | 329 | if current_owner_or_empty else |
| | 330 | _("The ticket will remain without an owner")) |
| 326 | 331 | else: |
| 327 | 332 | if status != '*': |
| 328 | 333 | hints.append(_("Next status will be '%(name)s'", name=status)) |
Not 100% sure about the grammar though (or "with no owner"?).
Also, I hope this will not introduce doubts about what happens with the owner for the other actions where the owner won't change (e.g. assign / unassign / resolve). I don't want to add the "remains" hint for all of them, sounds too verbose. So unless someone has a better idea, I'm fine with the proposed change.
