Hash changeset ids are not allowed in revision log

[sterkrig@…]

According to TracLinks, the following markup styles are available for revision logs:

r1:3, [1:3] or log:@1:3, log:trunk@1:3, [2:5/trunk]

But I'm unable to use hash ids in either one of them. Let's try with cboos.git and its topmost changesets:

• log:cboos.git@ec351621:f6b72a6a (had to be quoted, otherwise a ValueError is raised);
• [ec351621:f6b72a6a/cboos.git] (just unrecognized)

The same goes for Mercurial repos, but at least there are revnumbers, although they are of limited use due to their nature.

There are similar problems with default repository, but since here default repo is kept in SVN (what a shame!) I can't demonstrate it :)

[Christian Boos]

• log:cboos.git@ec351621:f6b72a6a (had to be quoted, otherwise a ValueError is raised);

This one is worth a fix on 1.0-stable.

The rest also deserve to be supported in some future version, I agree.

[Jun Omae]

Proposed changes can be found in log:jomae.git:t11050.

[Jun Omae]

Rebased the changes on latest of 1.0-stable, jomae.git@t11050v2.

[Peter Suter]

Seems to work well, and also helps with #11888.

I suspect in RevRanges.truncate it should be:

trac/versioncontrol/web_ui/util.py

@@ -292 +292 @@
                 break
             pairs.append(p)
         if pairs:
-            self.a = pairs[0][0]
-            self.b = pairs[-1][1]
+            ranges.a = pairs[0][0]
+            ranges.b = pairs[-1][1]
         return ranges
 
     def _reduce(self):

trac.versioncontrol.web_ui.util.RevRanges is a generalization of trac.util.Ranges that supports non-integer revisions, right? The comments from there help a lot.

RevRanges doesn't seem to use the path parameter, and only uses repos.normalize_rev from repos. Maybe it could become something like trac.util.GeneralRanges(r=[], normalize=int).

[Jun Omae]

Retargeting. Revised changes can be found in jomae.git@t11050v2. However, that is still broken. ​https://github.com/libgit2/pygit2/compare/v0.21.3...v0.21.4 shows 35 commits but Trac shows 9 revisions for log:@v0.21.3:v0.21.4.

[Jun Omae]

Again.

Retargeting. Revised changes can be found in jomae.git@t11050v2. However, that is still broken. ​https://github.com/libgit2/pygit2/compare/v0.21.3...v0.21.4 shows 35 commits but Trac shows 9 revisions for log:@v0.21.3:v0.21.4.

That occurs when log view with revision ranges walks merge commits. When the log view with revision ranges, Node.get_history(limit=2) is repeatedly called to retrieve next revision until the end of revision ranges. A merge commit has usually two parent commits. However Node.get_history(limit=2) returns only one of the parents….

We should create a new ticket for another issue, so I'll push proposed changes if no objections.

[Jun Omae]

That occurs when log view with revision ranges walks merge commits. When the log view with revision ranges, Node.get_history(limit=2) is repeatedly called to retrieve next revision until the end of revision ranges. A merge commit has usually two parent commits. However Node.get_history(limit=2) returns only one of the parents….

We should create a new ticket for another issue, so I'll push proposed changes if no objections.

That issue is fixed in [69ff00b96/jomae.git].

[Jun Omae]

I found breakages in the proposed changes. More testing is needed. Retargeting to next stable.

[Jun Omae]

Again and again. Proposed changes in log:jomae.git@t11050v3. I'll push it at start of milestone:1.0.6.

[Jun Omae]

Committed in [13919] and merged to trunk in [13920].