Enabled CommitTicketUpdater only for some repositories

[Mitar]

I am using CommitTicketUpdater on a Trac installation with multiple (git) repositories. The problem I am having is that for some of those repositories we are using GitHub for ticketing. And because CommitTicketUpdater listens to all comments, when somebody reference ticket with GitHub ticket number, a wrong reference is made in Trac. Would it be possible to enable CommitTicketUpdater only for some repositories?

[Jun Omae]

I have the similar problems which I use a subversion repository and the git-svn cloned repository.

I'm using the following script instead of CommitTicketUpdater. Set the repository names to [ticket] commit_ticket_update_ignore_repositories.

from trac.config import ListOption
from tracopt.ticket.commit_updater import CommitTicketUpdater

class MyCommitTicketUpdater(CommitTicketUpdater):

    ignore_repositories = ListOption(
        'ticket', 'commit_ticket_update_ignore_repositories', '',
        keep_empty=True,
        doc="""List of repository names that should not be updated tickets
        when the changes.

        Note that `(default)` can be used instead of an empty name for the
        default repository.""")

    def changeset_added(self, repos, changeset):
        if not self._is_ignored(repos):
            CommitTicketUpdater.changeset_added(self, repos, changeset)

    def changeset_modified(self, repos, changeset, old_changeset):
        if not self._is_ignored(repos):
            CommitTicketUpdater.changeset_modified(self, repos, changeset,
                                                    old_changeset)

    def _is_ignored(self, repos):
        if self.env.is_component_enabled(CommitTicketUpdater):
            return True
        reponame = repos.reponame
        if is_default(reponame):
            if '(default)' in self.ignore_repositories:
                return True
            reponame = ''
        return reponame in self.ignore_repositories

[Remy Blank]

This would be a worthwhile addition to CommitTicketUpdater.

[Mitar]

Thanks for the code.

[Jun Omae]

I'll push to 1.0-stable.

[Mitar]

Ping?

[Ryan J Ollos]

The change looks good and useful to me.

[Ryan J Ollos]

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

[Ryan J Ollos]

See ​#108 for trac-github, which requests the ability to selectively enable or disable CommitTicketUpdater for repository paths (branches).