Edgewall Software
Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#10856 closed defect (fixed)

[PATCH] Link "Modify" is not present anymore

Reported by: framay <franz.mayer@…> Owned by: Christian Boos
Priority: normal Milestone: 1.0.1
Component: ticket system Version: 1.0
Severity: normal Keywords: layout pagenav
Cc:
Release Notes:

Restore the Modify link at the top of the ticket page, as it was in Trac 0.12

API Changes:

Description

In Trac 0.12 was a "Modify" link present (right above the ticket box). This link opened the "Modify Ticket" section.

This link is very useful and used a lot in our Trac environment.

Attachments (5)

t10856-modify-link.diff (777 bytes ) - added by framay <franz.mayer@…> 6 years ago.
possible patch (modify-link as it was in Trac 0.12)
t10856-modify.patch (2.4 KB ) - added by franz.mayer@… 6 years ago.
Possible patch - it only needs a new line
t10856-modify.png (11.2 KB ) - added by franz.mayer@… 6 years ago.
Output of patch
t10856-modify-20121207.patch (6.1 KB ) - added by aleuhe 6 years ago.
Modify-20121207.png (4.0 KB ) - added by aleuhe 6 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 6 years ago by Christian Boos

Keywords: layout pagenav added
Milestone: next-stable-1.0.x

Now that I don't use the "Smooth Gestures" Chrome extension anymore… I indeed find that we could do something here ;-)

But it should somehow look less intrusive than it used to in 0.12.x.

Changed 6 years ago by framay <franz.mayer@…>

Attachment: t10856-modify-link.diff added

possible patch (modify-link as it was in Trac 0.12)

comment:2 in reply to:  1 Changed 6 years ago by framay <franz.mayer@…>

Replying to cboos:

But it should somehow look less intrusive than it used to in 0.12.x.

I don't find the "Modify" link very intrusive. So I made the first patch-approach like it was in version 0.12.

btw: Trac uses the style of that link still for the "Attachments ↑"-link at the bottom page.

comment:3 Changed 6 years ago by Christian Boos

comment:4 Changed 6 years ago by anonymous

What do you think about putting the functionality into tracopt?

So if someone (like us) would like to have the "Modify"-Link again, can just enable that tracopt module.

comment:5 Changed 6 years ago by Christian Boos

Maybe, or we find a sensible place, like an (\\ Edit) button in the description (like we have here for ticket comments). Or a user preference.

Changed 6 years ago by franz.mayer@…

Attachment: t10856-modify.patch added

Possible patch - it only needs a new line

Changed 6 years ago by franz.mayer@…

Attachment: t10856-modify.png added

Output of patch

comment:6 Changed 6 years ago by franz.mayer@…

Attached is a new version of the patch: t10856-modify.patch, which places the buttons "Edit" and "Clone" right on top of the properties table (see t10856-modify.png).

Putting the buttons right on top of properties table makes more sense to me, since when you click one of the buttons it affects the complete ticket (and not only the ticket description).

One thing, I don't like with that patch: The buttons need an additional line. But as I'm not a CSS expert, I don't know how to archive this; I tried it with removing clear: right; in #trac-ticket-title, but that didn't work.

comment:7 Changed 6 years ago by franz.mayer@…

Summary: Link "Modify" is not present anymore[PATCH] Link "Modify" is not present anymore

comment:8 Changed 6 years ago by Christian Boos

Milestone: next-stable-1.0.x1.0.1
Owner: set to Christian Boos
Status: newassigned

I just haven't had the time to look at it yet, but it looks promising. I'll try to integrate it for the next minor release.

comment:9 Changed 6 years ago by anonymous

I have recreated the patch. The "Modify" Link looks now simmilar to the "Clone" Button and is not displayed when the ticket is printed.

Changed 6 years ago by aleuhe

Changed 6 years ago by aleuhe

Attachment: Modify-20121207.png added

comment:10 Changed 5 years ago by Christian Boos

Thanks for your proposals. I'm entirely convinced by the latter patches, though there's something in there…

I'll give the topic another shot for 1.1.2, right after the current set of releases (1.0.1 and 1.1.1).

For now, I'd leave things as they are or just restore the 0.12 way (comment:1 and comment:3). What would (other) people prefer?

comment:11 in reply to:  10 ; Changed 5 years ago by franz.mayer@…

Replying to cboos:

Thanks for your proposals. I'm entirely convinced by the latter patches, though there's something in there…

What means "there's something in there…"? Do you mean the .project, .pydevproject files and such? These are eclipse specific (PyDev) files. I can give you a patch without that files by next week.

I'll give the topic another shot for 1.1.2, right after the current set of releases (1.0.1 and 1.1.1).

For now, I'd leave things as they are or just restore the 0.12 way (comment:1 and comment:3). What would (other) people prefer?

Well in our Trac environment the link is used quite often.

comment:12 in reply to:  11 ; Changed 5 years ago by Christian Boos

Replying to franz.mayer@…:

Replying to cboos:

Thanks for your proposals. I'm entirely convinced by the latter patches, though there's something in there…

What means "there's something in there…"?

Oh, I'm very sorry, I wanted to write: "I'm not entirely convinced". Quite a different meaning ;-)

I agree there's a need to find a nicer place somewhere at the top of the ticket page for the ticket "actions". But I don't think that squished between the dates and the summary is the best place (also consider we can have up to 3 dates). Maybe a vertical "toolbar" at the right side of the ticket box?

comment:14 in reply to:  12 ; Changed 5 years ago by franz.mayer@…

Replying to cboos:

Oh, I'm very sorry, I wanted to write: "I'm not entirely convinced". Quite a different meaning ;-)

I agree there's a need to find a nicer place somewhere at the top of the ticket page for the ticket "actions". But I don't think that squished between the dates and the summary is the best place (also consider we can have up to 3 dates). Maybe a vertical "toolbar" at the right side of the ticket box?

We considered in our Trac instance changing the structure of the ticket header.

Instead of rendering it as

#10856 assigned defect dates
buttons

header

Trac could render it as following:

#10856 assigned defect
header
dates
buttons

Would that be a more convincing solution?

This means that the header needs to be printed on a new line in this very ticket, but only when the ticket has a long summary.

Btw: we use 100% width of the browser instead of 58em for content class - why is Trac limiting the content to such a narrow width? Would 90% or such be better?

comment:15 in reply to:  13 Changed 5 years ago by Christian Boos

Resolution: fixed
Status: assignedclosed

comment:16 in reply to:  14 Changed 5 years ago by Christian Boos

Kept track of your suggestions in TracIdeas/TracTickets#Layout.

comment:17 Changed 5 years ago by Christian Boos

Release Notes: modified (diff)

comment:18 Changed 5 years ago by franz.mayer@…

There should be some space between the elements in the div[@class=trac-topnav] (as it is with elements in div[@class=trac-nav], such as "Attachments" and "Description").

  • trac/htdocs/css/ticket.css

     
    242242}
    243243fieldset.radio label { padding-right: 1em }
    244244
    245 #content.ticket .trac-nav a { margin-left: 1em; }
     245#content.ticket .trac-nav a, #content.ticket .trac-topnav a { margin-left: 1em; }

The margin is needed when the clone link is enabled (see ticket #10948).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.