[PATCH] Link "Modify" is not present anymore

[framay <franz.mayer@…>]

In Trac 0.12 was a "Modify" link present (right above the ticket box). This link opened the "Modify Ticket" section.

This link is very useful and used a lot in our Trac environment.

[Christian Boos]

Now that I don't use the "​Smooth Gestures" Chrome extension anymore… I indeed find that we could do something here ;-)

But it should somehow look less intrusive than it used to in 0.12.x.

[framay <franz.mayer@…>]

possible patch (modify-link as it was in Trac 0.12)

[framay <franz.mayer@…>]

Replying to cboos:

But it should somehow look less intrusive than it used to in 0.12.x.

I don't find the "Modify" link very intrusive. So I made the first patch-approach like it was in version 0.12.

btw: Trac uses the style of that link still for the "Attachments ↑"-link at the bottom page.

[Christian Boos]

+ the javascript… [11129/trunk/trac/ticket/templates/ticket.html#file0]

[anonymous]

What do you think about putting the functionality into tracopt?

So if someone (like us) would like to have the "Modify"-Link again, can just enable that tracopt module.

[Christian Boos]

Maybe, or we find a sensible place, like an (\\ Edit) button in the description (like we have here for ticket comments). Or a user preference.

[franz.mayer@…]

Possible patch - it only needs a new line

[franz.mayer@…]

Output of patch

[franz.mayer@…]

Attached is a new version of the patch: t10856-modify.patch​, which places the buttons "Edit" and "Clone" right on top of the properties table (see t10856-modify.png​).

Putting the buttons right on top of properties table makes more sense to me, since when you click one of the buttons it affects the complete ticket (and not only the ticket description).

One thing, I don't like with that patch: The buttons need an additional line. But as I'm not a CSS expert, I don't know how to archive this; I tried it with removing clear: right; in #trac-ticket-title, but that didn't work.

[Christian Boos]

I just haven't had the time to look at it yet, but it looks promising. I'll try to integrate it for the next minor release.

[anonymous]

I have recreated the patch. The "Modify" Link looks now simmilar to the "Clone" Button and is not displayed when the ticket is printed.

[Christian Boos]

Thanks for your proposals. I'm entirely convinced by the latter patches, though there's something in there…

I'll give the topic another shot for 1.1.2, right after the current set of releases (1.0.1 and 1.1.1).

For now, I'd leave things as they are or just restore the 0.12 way (comment:1 and comment:3). What would (other) people prefer?

[franz.mayer@…]

Replying to cboos:

Thanks for your proposals. I'm entirely convinced by the latter patches, though there's something in there…

What means "there's something in there…"? Do you mean the .project, .pydevproject files and such? These are eclipse specific (PyDev) files. I can give you a patch without that files by next week.

I'll give the topic another shot for 1.1.2, right after the current set of releases (1.0.1 and 1.1.1).

For now, I'd leave things as they are or just restore the 0.12 way (comment:1 and comment:3). What would (other) people prefer?

Well in our Trac environment the link is used quite often.

[Christian Boos]

Replying to franz.mayer@…:

Replying to cboos:

Thanks for your proposals. I'm entirely convinced by the latter patches, though there's something in there…

What means "there's something in there…"?

Oh, I'm very sorry, I wanted to write: "I'm not entirely convinced". Quite a different meaning ;-)

I agree there's a need to find a nicer place somewhere at the top of the ticket page for the ticket "actions". But I don't think that squished between the dates and the summary is the best place (also consider we can have up to 3 dates). Maybe a vertical "toolbar" at the right side of the ticket box?

[Christian Boos]

See repos:cboos.git:ticket10856-restore-modify-link.

[franz.mayer@…]

Replying to cboos:

Oh, I'm very sorry, I wanted to write: "I'm not entirely convinced". Quite a different meaning ;-)

I agree there's a need to find a nicer place somewhere at the top of the ticket page for the ticket "actions". But I don't think that squished between the dates and the summary is the best place (also consider we can have up to 3 dates). Maybe a vertical "toolbar" at the right side of the ticket box?

We considered in our Trac instance changing the structure of the ticket header.

Instead of rendering it as

#10856 assigned defect	dates buttons
header

Trac could render it as following:

#10856 assigned defect header

dates buttons

Would that be a more convincing solution?

This means that the header needs to be printed on a new line in this very ticket, but only when the ticket has a long summary.

Btw: we use 100% width of the browser instead of 58em for content class - why is Trac limiting the content to such a narrow width? Would 90% or such be better?

[Christian Boos]

Replying to cboos:

See repos:cboos.git:ticket10856-restore-modify-link.

Applied in r11536.

[Christian Boos]

Kept track of your suggestions in TracIdeas/TracTickets#Layout.

[franz.mayer@…]

There should be some space between the elements in the div[@class=trac-topnav] (as it is with elements in div[@class=trac-nav], such as "Attachments" and "Description").

trac/htdocs/css/ticket.css

@@ -242 +242 @@
 }
 fieldset.radio label { padding-right: 1em }
 
-#content.ticket .trac-nav a { margin-left: 1em; }
+#content.ticket .trac-nav a, #content.ticket .trac-topnav a { margin-left: 1em; }

The margin is needed when the clone link is enabled (see ticket #10948).