include date picker into admin panel and timeline

[framay <franz.mayer@…>]

When adding / changing milestone via "Roadmap" date picker is working fine (see ticket #10245).

It would be nice if the date picker would also be included when adding / changing milestones via admin panel.

Another place where a date picker would be useful is in Timeline view.

[Ryan J Ollos <ryano@…>]

On the Admin page it could be used on the Versions panel as well. We've previously used the ​th:DateFieldPlugin for this.

[Ryan J Ollos <ryano@…>]

The implementation seems fairly straightforward since Pete did all the real work in #10245, [10992:10993].

Here is a patch that adds a date or datetime picker to the following locations:

• Admin panel: Version release date (datetime picker)
• Admin panel: Milestone due date and completed date (datetime picker)
• Timeline: filter from date (date picker)
• Custom query: Created by constraint (date picker)

I'm not confident that I implemented the date picker for the Custom query Created by constraint correctly. The way it is implemented, Chrome(self.env).add_jquery_ui(req) must be called together with add_script(req, 'common/js/query.js').

I'm hoping to get some feedback on the patch.

[Ryan J Ollos <ryano@…>]

Related issue: ​th:DateFieldPlugin will be modified in ​th:#10107 to utilize the jQuery UI date picker and datetime picker that ships with Trac 1.0. The plugin would be obsolete though if the Trac core had a way to add a date or datetime picker to a custom field.

[Remy Blank]

Replying to Ryan J Ollos <ryano@…>:

The plugin would be obsolete though if the Trac core had a way to add a date or datetime picker to a custom field.

This should be done in the context of #1942 (and maybe already is, I don't remember).

[Peter Suter]

Replying to rblank:

add a date or datetime picker to a custom field.

This should be done in the context of #1942 (and maybe already is, I don't remember).

Yes, comment:72:ticket:1942 mentions ​datetimepicker.patch, which adds date pickers for all custom date fields on the query and ticket pages.

Replying to Ryan J Ollos <ryano@…>:

I'm not confident that I implemented the date picker for the Custom query Created by constraint correctly. The way it is implemented, Chrome(self.env).add_jquery_ui(req) must be called together with add_script(req, 'common/js/query.js').

I'm hoping to get some feedback on the patch.

Looks good to me. In that custom field ​datetimepicker.patch I used the same approach.

[Peter Suter]

Reviewed and tested. I couldn't find anything wrong with this patch. It nicely completes the effort started in #10245. Committed in [11104].