[PATCH] CommitTicketUpdater does not allow user to define what state to jump to

[patrick.little]

The CommitTicketUpdater will only ever close a ticket. In general, the closed state is for when no more work is to be done, aka after QA has verified the fix. Trac should allow configuration of what state name the ticket will get updated to.

[anonymous]

Yes, this would be a nice feature. I've wanted to be able to define reopens as a keyword that changes the state of the ticket to reopened, as well as transition tickets that are fixed from accepted → implemented, rather than from accepted to closed.

[clemens@…]

This would be cool!

In addition, it would be great if the CommitTicketUpdater would use the default_resolution configured in the [ticket] section of trac.ini if no other state has been specified. Currently, it sets the state to fixed (hard-coded in commit_updater.py, line 251), although my custom workflow has no fixed state.

[Paul Wise <pabs3@…>]

For those who are looking for a workaround for this lack of feature, I added a simple plugin to do what I wanted:

from tracopt.ticket.commit_updater import CommitTicketUpdater

class CustomCommitTicketUpdater(CommitTicketUpdater):

	def cmd_close(self, ticket, changeset, perm):
		if not self.check_perms or 'TICKET_MODIFY' in perm:
			ticket['status'] = 'reviewing'
			ticket['owner'] = ticket['reporter']

[patrick.little@…]

Replying to Paul Wise <pabs3@…>:

For those who are looking for a workaround for this lack of feature, I added a simple plugin to do what I wanted:

from tracopt.ticket.commit_updater import CommitTicketUpdater

class CustomCommitTicketUpdater(CommitTicketUpdater):

	def cmd_close(self, ticket, changeset, perm):
		if not self.check_perms or 'TICKET_MODIFY' in perm:
			ticket['status'] = 'reviewing'
			ticket['owner'] = ticket['reporter']

I've tried following the various tutorials and I just can't get the plugin to show up in my admin panel. I can follow the t-h.o egg cooking tutorial and get the helloworld example to show up, but when I switch over to this code nothing shows up.

[Christian Boos]

A few configuration options for the commit ticket updater could indeed help.

PatchWelcome.

[brad@…]

I find that the simple plugin approach works but there's something odd going on as the ticket goes to 'closed' first and then the custom updater moves it to 'reviewing' (or 'test' or whatever), resulting in two entries in the ticket's history. It's like the base implementation is being called and the simple plugin is not overriding that behaviour. Am I missing something simple here?

[Remy Blank]

If your plugin subclasses CommitTicketUpdater, you need to disable the base component (tracopt.ticket.commit_updater.CommitTicketUpdater) in trac.ini.

[anonymous]

Replying to rblank:

If your plugin subclasses CommitTicketUpdater, you need to disable the base component (tracopt.ticket.commit_updater.CommitTicketUpdater) in trac.ini.

That works perfectly. Many thanks.

[patrick.little@…]

Please clear the reported by field - I no longer am using Trac and do not want to keep getting ticket updates when something changes.

[Ryan J Ollos]

#11947 closed as a duplicate.

[Ryan J Ollos]

TODO Add documentation when implemented, see TracWorkflow@72.

See also 0.11/TracWorkflow.

[Ryan J Ollos]

#11093 and #12908 closed as duplicates.

[Michael Kriegel]

I am also very interested in this feature!

[Andreas Helmcke <ahelmcke@…>]

Patch for options for closed state and resolution.

[Andreas Helmcke <ahelmcke@…>]

Added a patch which addresses this problem. Patch is against current trunk (Rev. 17579)

The Patch introduces two new options: for [ticket]

option	description	default
commit_ticket_update_close_state	State to change to if a close command is detected.	closed
commit_ticket_update_close_resolution	Resolution to set, if closed state is closed.	fixed