Edgewall Software

Changes between Initial Version and Version 1 of Ticket #10752, comment 2


Ignore:
Timestamp:
Jul 25, 2012, 3:42:35 PM (12 years ago)
Author:
Christian Boos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10752, comment 2

    initial v1  
    55The feature looks pertinent. A few remarks about the patch however:
    66 - <text>? surely you meant <span>
    7  - `#permlist .missing` should be enough for the styling (no need to add //two// classes, as anyway you can't write a CSS rule targeting only elements having both classes)
     7 - `#permlist .missing` should be enough for the styling (~~no need to add //two// classes, as anyway you can't write a CSS rule targeting only elements having both classes~~ [http://www.w3.org/TR/CSS2/selector.html#class-html wrong])
    88 - a title attribute saying something like "invalid permission" would be useful for explaining the different styling