Edgewall Software

Changes between Initial Version and Version 1 of Ticket #10742, comment 8


Ignore:
Timestamp:
Sep 29, 2013, 10:39:53 AM (11 years ago)
Author:
Ryan J Ollos

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10742, comment 8

    initial v1  
    22>  1. `comment:N` and `comment:N:ticket:M` should display with class `missing comment` when ticket M does exist and the user has permission to view ticket M, but comment N does not exist. For example, compare: comment:1 vs comment:100000 and comment:1:ticket:1 vs comment:10000:ticket:1 - the latter in both comparisons the latter example should display as a missing link.
    33
    4 The `comment` class can't be used for TracLinks since it is already used on the ticket page for the `div` that encloses the comment text. I've the class `ticket-comment` instead. I wonder though whether there is any value in adding this class, or whether I should just use the `ticket` class for TracLinks prefixed with `ticket:` or `comment:`.
     4The `comment` class can't be used for TracLinks since it is already used on the ticket page for the `div` that encloses the comment text. I've added the class `ticket-comment` instead. I wonder though whether there is any value in adding this class, or whether I should just use the `ticket` class for TracLinks prefixed with `ticket:` or `comment:`.
    55
    66I plan to give this another thorough review in the next day or so, but the latest proposed changes can be found in [repos:rjollos.git:t10742].