provide a way to delete ticket comments from trac-admin

[Daniel Kahn Gillmor <dkg@…>]

trac-admin currently supports a way to remove entire tickets (ticket remove), but doesn't allow for removal of ticket comments. Removal of ticket comments through the webui is available via the tracopt.ticket.deleter component, but this feature is bundled with TICKET_ADMIN, which is quite powerful as well, and might not be something administrators want to expose via the web UI, even if ticket comment removal is occasionally needed.

The attached patch exposes the ability to remove ticket comments via trac-admin, using the new command:

ticket_comment remove

It applies and works for me against 0.12 — i haven't tested it against 0.13.

[Daniel Kahn Gillmor <dkg@…>]

patch to implement "ticket_comment remove" in trac-admin

[Christian Boos]

I just found an old note of mine about this ticket saying:

Seems to work quite fine. What could perhaps be improved is the error handling in case of wrong ticket or comment number (first concern is shared by the ticket remove command as well).

… which means I tested it some time ago ;-)

Sorry for the long delay and thanks for the patch, we'll look into integrating it.

[Ryan J Ollos]

Retargetting tickets to narrow focus for milestone:1.2. Please move the ticket back to milestone:next-dev-1.1.x if you intend to resolve it by milestone:1.2.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t10656_ticket_admin_comment_remove. I accidentally checked in the changes, then reverted ([15505:15506]).

Rather than adding a ticket remove_comment command, I considered changing the ticket remove command to take two arguments, <ticket#> <comment#>, with the second argument optional. However, I think there would be more risk in accidentally deleting a ticket if the second argument unintentionally omitted.

[Ryan J Ollos]

Committed to trunk in [15518:15519].

[Ryan J Ollos]

I don't know if it's important, but we aren't deleting just comments, so we often refer to the entries as ticket changes. Maybe the command should be named remove_change? I'll leave as is unless there is agreement that it should be renamed.