Opened 12 years ago
Last modified 11 years ago
#10642 closed defect
Rendered ticket action hints don't end with a fullstop — at Initial Version
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | lowest | Milestone: | 1.0.2 |
| Component: | ticket system | Version: | 0.13dev |
| Severity: | minor | Keywords: | grammar |
| Cc: | osimons | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
The default configuration of Trac trunk renders the hints for a ticket action without a trailing fullstop i.e.
The resolution will be set. Next status will be 'closed'
rather than
The resolution will be set. Next status will be 'closed'.
- ITicketActionController.render_ticket_action_control() documents a single hint should be returned for the action
- [ConfigurableTicketWorkflow.render_ticket_action_control() source:trunk/trac/ticket/default_workflow.py#L329] joins it's multiple hints into one string by performing
'. '.join(hints) - [Ticket.html source:trunk/trac/ticket/templates/ticket.html#L316] combines multiple hints (presumably in case more that one controller provides an action) by rendering each in a <span>
Ideally the displayed hint(s) would have a fullstop, since they're complete sentences. However th:XmlRpcPlugin currently joins the hints from multiple ITicketActionController by performing ". ".join(hints) + '.' - so having ConfigurableTicketWorkflow return "The resolution will be set. Next status will be 'closed'." would result in XmlRpcPlugin rendering a double fullstop.
Note:
See TracTickets
for help on using tickets.
