Opened 13 years ago
Last modified 10 years ago
#10414 closed defect
Changeset view broken for deleted files after upgrade to Subversion 1.7.0 — at Version 3
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | high | Milestone: | 0.12.3 |
Component: | version control | Version: | 0.11.7 |
Severity: | critical | Keywords: | svn17 |
Cc: | ryano@… | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description (last modified by )
Upgraded to Subversion 1.7.0 compiled by WanDisco on Centos 5.5.
New commits with file deletions no longer render in changeset view. Instead I get a "No node for /path in revision x" error.
Looking at the node_changes database, all the entries are marked E, even though the deletions should be marked D
Playing around on my test instance, I isolated the problem to a change in behavior between Subversion 1.6.x and 1.7.0. In Subversion 1.6.x, the change.path was None on a delete. In Subversion 1.7.0, the change.path is the path of the file that was deleted.
Recommend changing code
if not path: if base_path:
to
if change.action == repos.CHANGE_ACTION_DELETE: if base_path:
in svn_fs.py. Not sure if that breaks compatiiblity with old subversion bindings though.
Problem observed on 0.11.7 but seems to exist in 0.13dev too.
Change History (3)
comment:1 by , 13 years ago
Component: | general → version control |
---|---|
Milestone: | → 0.12.3 |
Priority: | normal → high |
Severity: | normal → critical |
comment:2 by , 13 years ago
Cc: | added |
---|
comment:3 by , 13 years ago
Description: | modified (diff) |
---|
Thanks for the report and fix! This should go into 0.12.3.