Edgewall Software

Changes between Initial Version and Version 1 of Ticket #10323, comment 13


Ignore:
Timestamp:
Sep 10, 2015, 5:47:06 AM (6 years ago)
Author:
Jun Omae

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10323, comment 13

    initial v1  
    22
    33 - The `pages_metadata` is incorrect. The latest version of each page should be cached. Also, we shouldn't use costly `DISTINCT` with all fields in the general cases.
    4  - Using both `pages_metadata` and `WikiSystem.get_pages()` is race.
     4 - Using both `pages_metadata` and `WikiSystem.get_pages()` is race. The `get_pages()` uses `pages` decorated `@cached`. I think we should use only `pages_metadata`.
     5 - We should invalidate the cache of `pages_metadata` when a page is saved, renamed and deleted. See `del WikiSystem(self.env).pages` in `trac/wiki/model.py` and `trac/wiki/admin.py`.
    56 - `UnboundLocalError` when `order=xxxxx` parameter is passed.
    67 - In the latest patch, uses of `index_order` for `tree_group` and `tree_hierarchy` are removed. Is that intentional?