Changeset 8199

Timestamp:

May 13, 2009, 2:38:46 AM (14 years ago)

Author:

Remy Blank

Message:

0.12dev: Merged [8161] from 0.11-stable, now that ​#G300 is fixed.

Location:

trunk

Files:

• . (modified) (2 props)
• Makefile.cfg.sample (modified) (1 prop)
• trac/ticket/admin.py (modified) (1 diff)
• trac/ticket/tests/functional.py (modified) (2 diffs)

trunk/trac/ticket/admin.py

@@ -283 +283 @@
                     for name in sel:
                         mil = model.Milestone(self.env, name, db=db)
-                        mil.delete(db=db)
+                        mil.delete(db=db, author=req.authname)
                     db.commit()
                     req.redirect(req.href.admin(cat, page))

trunk/trac/ticket/tests/functional.py

@@ -1273 +1273 @@
         tc.find('RegressionTestTicket6912b</a>[ \n\t]*</td>[ \n\t]*'
                 '<td class="owner"></td>', 's')
+
+
+class RegressionTestTicket8247(FunctionalTwillTestCaseSetup):
+    def runTest(self):
+        """Test for regression of http://trac.edgewall.org/ticket/8247
+        Author field of ticket comment corresponding to the milestone removal
+        was always 'anonymous'."""
+        name = "MilestoneRemove"
+        self._tester.create_milestone(name)
+        id = self._tester.create_ticket(info={'milestone': name})
+        ticket_url = self._tester.url + "/ticket/%d" % id
+        tc.go(ticket_url)
+        tc.find(name)
+        tc.go(self._tester.url + "/admin/ticket/milestones")
+        tc.formvalue('milestone_table', 'sel', name)
+        tc.submit('remove')
+        tc.go(ticket_url)
+        tc.find('<strong>milestone</strong>[ \n\t]*<em>%s</em> deleted' % name)
+        tc.find('Changed <a.*</a> ago by admin')
+        tc.notfind('anonymous')
 
 
@@ -1358 +1378 @@
     suite.addTest(RegressionTestTicket6912a())
     suite.addTest(RegressionTestTicket6912b())
+    suite.addTest(RegressionTestTicket8247())
 
     return suite