Changeset 17650

Timestamp:

Jan 13, 2023, 11:28:41 AM (9 months ago)

Author:

Jun Omae

Message:

1.4.4dev: automatically logs the exception and its traceback when NotificationSystem.notify raises an exception (refs #13515)

Location:

branches/1.4-stable/trac

Files:

• notification/api.py (modified) (3 diffs)
• ticket/web_ui.py (modified) (2 diffs)

branches/1.4-stable/trac/notification/api.py

@@ -24 +24 @@
 from trac.core import Component, Interface, ExtensionPoint
 from trac.util import as_bool, lazy, to_list
+from trac.util.text import exception_to_unicode
 
 
@@ -210 +211 @@
         self.author = author
 
+    def __repr__(self):
+        return '<%s realm=%r, category=%r, target=%r, time=%r, author=%r>' % \
+               (self.__class__.__name__, self.realm, self.category,
+                self.target, self.time, self.author)
+
 
 class NotificationSystem(Component):
@@ -371 +377 @@
         :param event: a `NotificationEvent`
         """
-        self.distribute_event(event, self.subscriptions(event))
+        try:
+            self.distribute_event(event, self.subscriptions(event))
+        except Exception as e:
+            self.log.error("Failure distributing event %r%s", event,
+                           exception_to_unicode(e, traceback=True))
+            raise
 
     def distribute_event(self, event, subscriptions):

branches/1.4-stable/trac/ticket/web_ui.py

@@ -1373 +1373 @@
             self.log.error("Failure sending notification on creation of "
                            "ticket #%s: %s",
-                           ticket.id, exception_to_unicode(e, traceback=True))
+                           ticket.id, exception_to_unicode(e))
             add_warning(req, tag_("The ticket has been created, but an error "
                                   "occurred while sending notifications: "
@@ -1413 +1413 @@
             except Exception as e:
                 self.log.error("Failure sending notification on change to "
-                               "ticket #%s: %s", ticket.id,
-                               exception_to_unicode(e, traceback=True))
+                               "ticket #%s: %s",
+                               ticket.id, exception_to_unicode(e))
                 # TRANSLATOR: The 'change' has been saved... (link)
                 change = _('change')