Edgewall Software

Changes between Version 41 and Version 42 of TracTicketsCustomTimeFields


Ignore:
Timestamp:
Jan 16, 2012, 2:05:51 AM (12 years ago)
Author:
Steffen Hoffmann
Comment:

some missed changes to complete preliminary rework

Legend:

Unmodified
Added
Removed
Modified

  • TracTicketsCustomTimeFields

    v41 v42  
    44
    55== Code review ==
    6 Proposed code changes for Trac `trunk` reside in a Mercurial repository at bitbucket.org ^note 1^. This repository isn't a repository clone, but a patch queue to Trac's SVN repository mirror to Mercurial instead:
     6Proposed code changes for Trac `trunk` reside in a Mercurial repository at bitbucket.org:
    77
    88 https://bitbucket.org/hasienda/trac-1942
    99
    10 Mercurial Queue (MQ) is a powerful tool to bring dynamic, mutable changesets to otherwise immutable changesets of this distributed version control system (DVCS). But anyone can use it as a patch stack with some meta-data. Just see the series file for the patch order and optionally more related information ^note 2^.
    11 
    12 The repo will not always apply cleanly to current Mercurial tip/SVN HEAD. But re-basing is easy with MQ, and this has potential to drive even rapid development towards custom time field support ^note 3^.
     10This repository isn't a repository clone, but a patch queue to Trac's SVN repository mirror to Mercurial instead. Mercurial Queue (MQ) is a powerful tool to bring dynamic, mutable changesets to otherwise immutable changesets of this distributed version control system (DVCS). But anyone can use it as a patch stack with some meta-data. Just see the series file for the patch order and optionally more related information ^note 1^.
     11
     12The patches will not always apply cleanly to current Mercurial tip/SVN HEAD. But re-basing is easy with MQ, and this has potential to drive even rapid development towards custom time field support ^note 2^.
    1313
    1414You're invited to pull right now, but save a backup of your db before testing, please. I never broke the db of my development system. However, there might still lure some serious bugs, that I'm currently not aware of but could hit you, so you may need your backup to recover from a bad db. You've been warned. See [#KnownBugs Known Bugs] for more details.
    … …  
    108108 * {{{ValueError: empty string for float()}}} on TracQuery: handled now by trying to parse strings not convertible to float
    109109 * {{{TypeError: unsupported type for timedelta microseconds component: unicode}}} on TracQuery: simply needed to take care for conversation of variable type 'string' to a number and handle custom time values in trac/ticket/templates/query_results.html separately from standard time fields
    110  * preview custom time stamp changes is throwing an exception on internal formatting: resolved after realizing, that we deal with different formats in _render_property_diff()
     110 * preview custom time stamp changes is throwing an exception on internal formatting: resolved after realising, that we deal with different formats in _render_property_diff()
    111111  a. string with POSIX microsecond time stamp from db, directed to ticket changes list
    112112  b. datetime.datetime values from user input for change-in-progress, directed to preview current custom time field changes