Changes between Version 4 and Version 5 of TracDev/Proposals/AdvancedNotification/IEmailDecorator

Timestamp:

Oct 19, 2013, 9:34:40 AM (11 years ago)

Author:

Peter Suter

Comment:

Raise a question about AlwaysEmailDecorator

TracDev/Proposals/AdvancedNotification/IEmailDecorator

@@ -52 +52 @@
     """Replaces the 'Reply-To' header for tickets with a dynamic email address.
 
-    Uses a new config option 'ticket_email_from'.
+    Uses a new config option 'ticket_smtp_replyto'.
     """
     implements(IEmailDecorator)
 
-    ticket_email_replyto = Option('notification', 'ticket_email_replyto', '__id__@localhost',
+    ticket_smtp_replyto = Option('notification', 'ticket_smtp_replyto', '__id__@localhost',
                 """Reply-To address for ticket notification emails.
 
@@ -70 +70 @@
 
 The following implementations are part of core Trac:
-* `trac.ticket.notification.mail.AlwaysEmailDecorator`: Implements `email_always_cc` and `email_always_bcc` configuration options.
+* `trac.ticket.notification.mail.AlwaysEmailDecorator`: Implements `smtp_always_cc` and `smtp_always_bcc` configuration options.
 
 Various other resolvers might be part of th:AnnouncerPlugin.
@@ -81 +81 @@
    * DONE Removed continuation-passing style (`next_decorator()`).
    * DONE Added `charset` parameter.
+
+== Open Questions
+
+=== Make !AlwaysEmailDecorator a subscriber instead?
+
+[th:comment:3:ticket:10676 For Announcer it was suggested] that the ''always CC / BCC'' configuration options should be implemented in a [wiki:INotificationSubscriber subscriber] instead, as in Announcer decorators can not influence email recipients.
+
+The [source:psuter/trac/notification/mail.py@cefae24eeddf:243-244,247-250#L233 proposed changes] instead fix this deficiency of decorators.
+
+Are there any other reasons to use a subscriber?