Timeline Ticket messages should strike out the ID if closed

[Adrian Holovaty <holovaty at gmail>]

It would be very useful if all "Ticket"-type messages on the timeline would strike out the ID for closed tickets.

For example, in this message:

"Ticket #987 created by mdc @ manbw.dk"

If Ticket #987 has since been resolved, the timeline "Ticket #987 created" message should strike out the "#987" — even if it's a "created" message.

This would convey more information: That the ticket was created but has since been closed.

[Christian Boos]

#2637 requested again the same thing.

Adding this on my virtual TODO list…

[Christian Boos]

I couldn't make it work for some reasons. I'll try harder later.

[Tim Hatch]

#4402 was marked as a duplicate.

[Christian Boos]

Not for 0.11.

[Tim Hatch]

Quick patch against r4937

[Tim Hatch]

Replying to cboos:

Not for 0.11.

Check out t991.diff​ - I think that's how the new context stuff is supposed to be accessed. However I think the db hit might be a bit much to do it that way especially when showing a large number of high-ticket days. As a config option the db hit would be a choice of the server admin though.

I'm +1 on this feature's availability and am not sure if the punting to 0.12 was just because there's no patch or if there's some discussion I'm missing.

[Christian Boos]

The use of the API is correct, but the db hit would be a bit too much, check the ​Timeline -> much slower thread.

I've looked at the code again, and it seems quite possible to get the current status (current_status is probably a better name than master_status) from the query line 219​.

Like most tickets that will get shifted to 0.12, the purpose here was more to clean-up the field and to better reflect what could realistically go into the 0.11 release than to prevent something to be implemented for 0.11 ;-)

[adrya.stembridge@…]

I'm using Trac 1.0.1 and this is still a problem. I see that someone unscheduled this task 3 years ago. Could we consider putting it back into the queue and having it implemented?

[Jun Omae]

Anyone might dislike use of closedticket class in timeline.css, we could be the following….?

trac/htdocs/css/timeline.css

@@ -41 +41 @@
  font-style: normal;
  text-decoration: none;
 }
+dt.closedticket em { text-decoration: line-through }
 dt .time { color: #999; font-size: 80%; }
 dt .author { color: #666; }
 dt.highlight { background-color: #ffa; }

[Christian Boos]

That would only strike through a "closed" event, not all the create/edit timeline events for that ticket, if that ticket is currently closed.

There's probably a way to rework t991.diff​​ so that the current status is gathered only once for each ticket in the time span (using one separate query?).

[Ryan J Ollos]

Topic raised on the ​mailing list.